Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup project pom file #618

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Cleanup project pom file #618

merged 1 commit into from
Jul 31, 2022

Conversation

slawekjaranowski
Copy link
Member

  • use configuration and plugins version from parent
  • execute mrm in run-its profile
  • remove plexus-container-default from dependencies
  • add breadcrumbs for site

@slawekjaranowski
Cleanup project pom file
6499afc 
- use configuration and plugins version from parent
- execute mrm in run-its profile
- remove plexus-container-default from dependencies
- add breadcrumbs for site
@bmarwell
Copy link
Contributor

If you merge this, it'll break #619

Do we want to split the plug-in into a multi module project?

@slawekjaranowski
Copy link
Member Author

I known that #619 can be break by it.

I think that split project to multi module project will open easy way for creating extension for plugin.

So extension can have only dependency to api not internal plugin implementation and all transitive dependencies.

@slawekjaranowski slawekjaranowski merged commit 908c182 into master Jul 31, 2022
@slawekjaranowski slawekjaranowski deleted the pom-cleanup branch July 31, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboutemy hboutemy Awaiting requested review from hboutemy

@khmarbaise khmarbaise Awaiting requested review from khmarbaise

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @bmarwell