Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #469 Support.property file in set-property #470

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Fixes #469 Support.property file in set-property #470

merged 1 commit into from
Jul 25, 2021

Conversation

arkel-s
Copy link
Contributor

@arkel-s arkel-s commented Jul 5, 2021 •
edited
Loading

Fixes #469
Possibility to use set-property with -DpropertiesVersionsFile to set multiple properties.

Useful to update values of multiples properties in pom with 1 call.

Example:

#test.properties
compo1.version=1.2.3
compo2.version=4.5.6

To update all properties in pom.xml in one call:

  mvn version:set-property -DpropertiesVersionsFile=test.properties

@obfischer
Copy link
Contributor

Your pull request is not linked with the issue you are referring to.

@obfischer
Copy link
Contributor

BTW, nice addition to the plugin

@arkel-s arkel-s force-pushed the feat/469_support_properties_file_set-version branch from 5aa08cd to 63b249b Compare July 6, 2021 10:17
@arkel-s
Copy link
Contributor Author

arkel-s commented Jul 6, 2021

Thanks for your very quick feedback @obfischer !

@arkel-s arkel-s force-pushed the feat/469_support_properties_file_set-version branch from 63b249b to 8cb61ad Compare July 6, 2021 10:21
obfischer
obfischer suggested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@obfischer obfischer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last suggestion for changes...

src/site/apt/index.apt Outdated Show resolved Hide resolved
src/test/java/org/codehaus/mojo/versions/utils/PropertiesVersionsFileReaderTest.java Outdated Show resolved Hide resolved
src/test/java/org/codehaus/mojo/versions/utils/PropertiesVersionsFileReaderTest.java Outdated Show resolved Hide resolved
src/test/java/org/codehaus/mojo/versions/utils/PropertiesVersionsFileReaderTest.java Outdated Show resolved Hide resolved
@obfischer
Copy link
Contributor

@arkel-s: Your pull request is not linked with the corresponding issue. Please try to fix this by editing you initial comment and add there Fixes #469.

@arkel-s arkel-s force-pushed the feat/469_support_properties_file_set-version branch from 512cb10 to 859258a Compare July 7, 2021 07:23
@arkel-s arkel-s changed the title Fixed #469 Support.property file in set-property Fixes #469 Support.property file in set-property Jul 7, 2021
@arkel-s
Copy link
Contributor Author

arkel-s commented Jul 7, 2021

@arkel-s: Your pull request is not linked with the corresponding issue. Please try to fix this by editing you initial comment and add there Fixes #469.

Done!

olamy
olamy requested changes Jul 12, 2021
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work. Thanks to contribute.
Just minor changes maybe?

ReleaseNotes.md Outdated
@@ -1,5 +1,20 @@
# Release Notes

* [Fixed Issue 469][issue-469]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need of this anymore. Release notes are now automatically generated https://github.com/mojohaus/versions-maven-plugin/releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and README updated accordingly

src/main/java/org/codehaus/mojo/versions/utils/PropertiesVersionsFileReader.java Show resolved Hide resolved
src/test/java/org/codehaus/mojo/versions/utils/PropertiesVersionsFileReaderTest.java Outdated Show resolved Hide resolved
@arkel-s @gselig1a
Fixes mojohaus#469 Support.property file in set-property
01093a8 
Possibility to use set-property with the new `-DpropertiesVersionsFile=test.properties`
to set one or multiple properties.
@arkel-s arkel-s force-pushed the feat/469_support_properties_file_set-version branch from 859258a to 01093a8 Compare July 12, 2021 14:43
@olamy olamy merged commit 30f0d36 into mojohaus:master Jul 25, 2021
@arkel-s
Copy link
Contributor Author

arkel-s commented Jul 26, 2021

Thanks for reviewing and merging my PR @olamy and @obfischer :-)
It was my first code contribution to open source.

@arkel-s
Copy link
Contributor Author

arkel-s commented Sep 29, 2021

Hello @obfischer and @olamy , do you know when a new release of versions-maven-plugin is planned?
The current one (2.8.1) is more than 1 year old, and I'm looking forward to use my new feature. Thanks :-)

@gvisokinskas gvisokinskas mentioned this pull request Jan 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarwell bmarwell bmarwell left review comments

@obfischer obfischer obfischer requested changes

@olamy olamy olamy requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support .properties file input in set-property, to update many properties as the same time
4 participants
@arkel-s @obfischer @olamy @bmarwell