#123 filter artifacts per scope

src/it/it-compare-dependencies-001/invoker.properties → src/it/it-compare-dependencies-006/invoker.properties

@@ -1,2 +1,2 @@
-invoker.goals=${project.groupId}:${project.artifactId}:${project.version}:compare-dependencies
+invoker.goals=${project.groupId}:${project.artifactId}:${project.version}:compare-dependencies -Dscope=compile
 invoker.systemPropertiesFile = test.properties

src/it/it-compare-dependencies-001/pom.xml → src/it/it-compare-dependencies-006/pom.xml

@@ -6,8 +6,11 @@
   <artifactId>it-compare-dependencies-001</artifactId>
   <version>1.0</version>
   <packaging>pom</packaging>
-  <name>compare dependency versions</name>
-
+  <name>#123 add scope filter property</name>
+  <description>
+    the scope filter property to allow excluding artifacts based on scope:
+    junit is set to test scope and we ask a comparison in scope compile
+  </description>
   <dependencyManagement>
 
     <dependencies>
@@ -20,7 +23,8 @@
       <dependency>
         <groupId>junit</groupId>
         <artifactId>junit</artifactId>
-        <version>4.1</version>
+        <version>4.0</version>
+        <scope>test</scope>
       </dependency>
 
     </dependencies>

src/it/it-compare-dependencies-001/verify.bsh → src/it/it-compare-dependencies-006/verify.bsh

@@ -8,7 +8,12 @@ try
 
     if ( buf.indexOf( "2.0.10 -> 2.0.9" ) < 0 )
     {
-        System.err.println( "Version diff in maven artifact not found" );
+        System.err.println( "Version diff in maven artifact not found. it should be processed because its scope is compile" );
+        return false;
+    }
+    if ( buf.indexOf( "4.0 -> 4.1" ) > 0 )
+    {
+        System.err.println( "Version diff in junit artifact found. it should be excluded because its scope is test" );
         return false;
     }
 }

src/main/java/org/codehaus/mojo/versions/AbstractVersionsDependencyUpdaterMojo.java

@@ -28,6 +28,7 @@
 import org.apache.commons.lang.StringUtils;
 import org.apache.maven.artifact.Artifact;
 import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
+import org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter;
 import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
 import org.apache.maven.model.Dependency;
 import org.apache.maven.model.Parent;
@@ -92,6 +93,15 @@ public abstract class AbstractVersionsDependencyUpdaterMojo
     @Parameter
     private String[] excludes = null;
 
+
+    /**
+     * a scope to use to filter the artifacts matching the asked scope or better
+     *
+     * @since 2.8
+     */
+    @Parameter(property = "scope")
+    private String scope = null;
+
     /**
      * Whether to process the dependencies section of the project.
      *
@@ -381,6 +391,12 @@ protected boolean isIncluded( Artifact artifact )
             result = result && excludesFilter.include( artifact );
         }
 
+        ArtifactFilter scopeFilter = this.getScopeArtifactFilter();
+
+        if (scopeFilter != null) {
+            result = result && scopeFilter.include(artifact);
+        }
+
         return result;
     }
 
@@ -430,6 +446,14 @@ else if ( excludes != null )
         return excludesFilter;
     }
 
+    private ArtifactFilter getScopeArtifactFilter() {
+        if (scope == null) {
+            return null;
+        }
+        return new ScopeArtifactFilter(scope);
+    }
+
+
     /**
      * To handle multiple includes with version range like "group:artifact:jar:[1.0.0,2.2)", we have to use a parsing a
      * little bit more complex than split().