Upgrade to Doxia 2.x stack #1180

slawekjaranowski · 2024-11-09T16:55:09Z

versions-maven-plugin/src/it/it-display-parent-updates-no-updates/invoker.properties

andrzejj0 · 2024-11-09T17:38:43Z

Something's not right. I've tried creating a plugin-updates-report on Modello, and got a problem.

mvn org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT:plugin-updates-report -DallowSnapshots=true -X

[ERROR] Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT:plugin-updates-report (default-cli) on project modello: An error has occurred in Plugin Updates Report report generation.: Failed to create context for skin: Cannot use skin: has [1.11.1,2.0.0-M1) Doxia Sitetools prerequisite, but current is 2.0.0 -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT:plugin-updates-report (default-cli) on project modello: An error has occurred in Plugin Updates Report report generation.

and

Caused by: org.apache.maven.doxia.siterenderer.RendererException: Cannot use skin: has [1.11.1,2.0.0-M1) Doxia Sitetools prerequisite, but current is 2.0.0
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.createContextForSkin (DefaultSiteRenderer.java:703)
at org.apache.maven.reporting.AbstractMavenReport.createSiteRenderingContext (AbstractMavenReport.java:312)
at org.apache.maven.reporting.AbstractMavenReport.reportToSite (AbstractMavenReport.java:254)
at org.apache.maven.reporting.AbstractMavenReport.execute (AbstractMavenReport.java:212)

See log:

plugin-updates-report.txt

EDIT: I see, it uses the skin as defined in the project's site.xml.

michael-o · 2024-11-09T20:30:19Z

Something's not right. I've tried creating a plugin-updates-report on Modello, and got a problem.
mvn org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT:plugin-updates-report -DallowSnapshots=true -X
[ERROR] Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT:plugin-updates-report (default-cli) on project modello: An error has occurred in Plugin Updates Report report generation.: Failed to create context for skin: Cannot use skin: has [1.11.1,2.0.0-M1) Doxia Sitetools prerequisite, but current is 2.0.0 -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT:plugin-updates-report (default-cli) on project modello: An error has occurred in Plugin Updates Report report generation.

and

Caused by: org.apache.maven.doxia.siterenderer.RendererException: Cannot use skin: has [1.11.1,2.0.0-M1) Doxia Sitetools prerequisite, but current is 2.0.0 at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.createContextForSkin (DefaultSiteRenderer.java:703) at org.apache.maven.reporting.AbstractMavenReport.createSiteRenderingContext (AbstractMavenReport.java:312) at org.apache.maven.reporting.AbstractMavenReport.reportToSite (AbstractMavenReport.java:254) at org.apache.maven.reporting.AbstractMavenReport.execute (AbstractMavenReport.java:212)

See log:

plugin-updates-report.txt

EDIT: I see, it uses the skin as defined in the project's site.xml.

See

[INFO] Rendering content with org.apache.maven.skins:maven-fluido-skin:jar:1.12.0 skin
You need to upgrade the skin.

michael-o

As a rule of thumb: Regular mojo classes should end with Mojo, but report mojos with Report only.

slawekjaranowski · 2024-11-10T18:05:54Z

As a rule of thumb: Regular mojo classes should end with Mojo, but report mojos with Report only.

Renamed

michael-o

No objections except for VelocityConfigurator.

michael-o · 2024-11-12T14:59:24Z

versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/VelocityConfigurator.java

+    public void configure(Properties properties) {
+        // nothing to do
+    }
+}


I don't understand why this happens at all..

I also don't understand it .... maybe @cstamas, @kwin or @gnodet can help why @Nullable is not respected on DefaultVelocityComponent

One I see - in
AbstractMavenReport we have:

@Component protected Renderer siteRenderer;

but in DependencyUpdatesRepor we use @Inject on constructor ....

The injection is failing only for the tests which don't invoke the plugin using site but invoke it directly.

So, only the following tests fail:

[ERROR] The following builds failed: [ERROR] * it-dependency-updates-report-issue-951/pom.xml [ERROR] * it-dependency-updates-report-issue-755/pom.xml [ERROR] * it-dependency-updates-report-issue-684-001/pom.xml

Maybe the problem is not correctly reported? I'm going to try to debug it and compare both cases (via reporting and directly).

Debugging is a bit difficult: actual version of sisu depends on the current version of Maven one is using (for 3.9.9 it's 0.9.0.M3). For what it's worth, I've only tested this with Maven 3.9.9 and 3.6.3 so far.

It looks pretty strange, as if @Nullable had no effect:

one remarks
when report is loading by m-site-p error not occurs,
only exist when report is directly loaded by Maven

the same report in one case works and in other not

it-dependency-updates-report-issue-951 - direct call report with error

it-dependency-updates-report-001 - configured as a site report - ok

I don't see nothing special in dependencies

direct-call.txt
site-report.txt

and diff:

--- direct-call.txt 2024-11-12 20:56:54 +++ site-report.txt 2024-11-12 20:59:23 @@ -57,6 +57,16 @@ [DEBUG] Created new class realm plugin>org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT [DEBUG] Importing foreign packages into class realm plugin>org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT [DEBUG] Imported: < maven.api +[DEBUG] Imported: org.apache.maven.doxia.logging.Log < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.apache.maven.doxia.logging.LogEnabled < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.apache.maven.doxia.sink.Sink < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.apache.maven.doxia.sink.SinkEventAttributes < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.apache.maven.doxia.sink.SinkFactory < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.apache.maven.doxia.siterenderer.Renderer < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.apache.maven.doxia.siterenderer.SiteRenderer < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.apache.maven.reporting.MavenMultiPageReport < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.apache.maven.reporting.MavenReport < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 +[DEBUG] Imported: org.codehaus.doxia.sink.Sink < plugin>org.apache.maven.plugins:maven-site-plugin:3.20.0 [DEBUG] Populating class realm plugin>org.codehaus.mojo:versions-maven-plugin:2.18.0-SNAPSHOT [DEBUG] Included: org.codehaus.mojo:versions-maven-plugin:jar:2.18.0-SNAPSHOT [DEBUG] Included: org.codehaus.mojo.versions:versions-api:jar:2.18.0-SNAPSHOT @@ -66,13 +76,11 @@ [DEBUG] Included: org.apache.commons:commons-collections4:jar:4.4 [DEBUG] Included: org.codehaus.plexus:plexus-xml:jar:3.0.1 [DEBUG] Included: org.apache.maven.shared:maven-common-artifact-filters:jar:3.4.0 -[DEBUG] Included: org.apache.maven.reporting:maven-reporting-api:jar:4.0.0 [DEBUG] Included: org.apache.maven.reporting:maven-reporting-impl:jar:4.0.0 [DEBUG] Included: org.apache.maven.shared:maven-shared-utils:jar:3.4.2 [DEBUG] Included: org.apache.maven.doxia:doxia-site-model:jar:2.0.0 [DEBUG] Included: org.apache.maven.doxia:doxia-integration-tools:jar:2.0.0 [DEBUG] Included: org.codehaus.plexus:plexus-interpolation:jar:1.27 -[DEBUG] Included: org.apache.maven.doxia:doxia-site-renderer:jar:2.0.0 [DEBUG] Included: org.apache.maven.doxia:doxia-skin-model:jar:2.0.0 [DEBUG] Included: org.apache.maven.doxia:doxia-module-xhtml5:jar:2.0.0 [DEBUG] Included: org.codehaus.plexus:plexus-velocity:jar:2.2.0 @@ -96,7 +104,6 @@ [DEBUG] Included: org.apache.maven.doxia:doxia-core:jar:2.0.0 [DEBUG] Included: commons-io:commons-io:jar:2.17.0 [DEBUG] Included: org.apache.commons:commons-text:jar:1.12.0 -[DEBUG] Included: org.apache.maven.doxia:doxia-sink-api:jar:2.0.0 [DEBUG] Included: org.codehaus.plexus:plexus-i18n:jar:1.0-beta-10 [DEBUG] Included: org.codehaus.plexus:plexus-interactivity-api:jar:1.3 [DEBUG] Included: com.fasterxml.woodstox:woodstox-core:jar:7.1.0

Please add:

<dependency> <groupId>org.eclipse.sisu</groupId> <artifactId>org.eclipse.sisu.inject</artifactId>  <version>0.3.4</version> </dependency>

this solves the issue.

VelocityConfigurator removed ... @andrzejj0 thanks for investigate
We need a org.eclipse.sisu.inject on classpath

fix: #1168

versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/VelocityConfigurator.java

andrzejj0 · 2024-11-12T18:46:09Z

versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/VelocityConfigurator.java

+    public void configure(Properties properties) {
+        // nothing to do
+    }
+}


The injection is failing only for the tests which don't invoke the plugin using site but invoke it directly.

So, only the following tests fail:

[ERROR] The following builds failed: [ERROR] * it-dependency-updates-report-issue-951/pom.xml [ERROR] * it-dependency-updates-report-issue-755/pom.xml [ERROR] * it-dependency-updates-report-issue-684-001/pom.xml

Maybe the problem is not correctly reported? I'm going to try to debug it and compare both cases (via reporting and directly).

andrzejj0 · 2024-11-12T19:16:00Z

versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/VelocityConfigurator.java

+    public void configure(Properties properties) {
+        // nothing to do
+    }
+}


Debugging is a bit difficult: actual version of sisu depends on the current version of Maven one is using (for 3.9.9 it's 0.9.0.M3). For what it's worth, I've only tested this with Maven 3.9.9 and 3.6.3 so far.

It looks pretty strange, as if @Nullable had no effect:

andrzejj0 · 2024-11-12T20:38:24Z

versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/VelocityConfigurator.java

+    public void configure(Properties properties) {
+        // nothing to do
+    }
+}


Hmmm I suppose it might add the injected dependency (VelocityComponentConfigurator) which is otherwise not present.

The real question is why this nullable seems not to work.

But we could also just patch it up somehow by also providing this missing dependency.

Regardless, this doesn't seem like a bug in Versions Maven Plugin, adding this dummy dependency that Jarek created should work around the problem.

Edit: it turns out that when invoked as site, the dependency is null -- @Nullable is suddenly honoured.

andrzejj0 · 2024-11-13T06:57:56Z

versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/VelocityConfigurator.java

+    public void configure(Properties properties) {
+        // nothing to do
+    }
+}


Please add:

<dependency> <groupId>org.eclipse.sisu</groupId> <artifactId>org.eclipse.sisu.inject</artifactId>  <version>0.3.4</version> </dependency>

this solves the issue.

slawekjaranowski · 2024-11-13T08:56:51Z

@andrzejj0 - already done - https://github.com/mojohaus/versions/compare/dac9646b1dcaac33ec5ac88902485a5cd5104fc1..ea84a013593b2111367f9cd2c3e3beb0b780689b

andrzejj0 · 2024-11-13T08:58:17Z

Yes I saw - and approved!

slawekjaranowski added enhancement dependencies Pull requests that update a dependency file labels Nov 9, 2024

slawekjaranowski added this to the 2.18.0 milestone Nov 9, 2024

slawekjaranowski requested review from michael-o, andrzejj0 and slachiewicz November 9, 2024 16:55

This was linked to issues Nov 9, 2024

Transitive Dependency Vulnerability - Dom4J 1.6.1 #1102

Open

Log4j 2.12.1 getting download it when running pluggin commands #1175

Open

andrzejj0 reviewed Nov 9, 2024

View reviewed changes

versions-maven-plugin/src/it/it-display-parent-updates-no-updates/invoker.properties Show resolved Hide resolved

andrzejj0 approved these changes Nov 9, 2024

View reviewed changes

michael-o reviewed Nov 9, 2024

View reviewed changes

slawekjaranowski force-pushed the doxia-2.x branch from 299b13b to dac9646 Compare November 10, 2024 18:04

slawekjaranowski requested a review from michael-o November 10, 2024 18:06

michael-o approved these changes Nov 12, 2024

View reviewed changes

Upgrade to Doxia 2.x stack

ea84a01

fix: #1168

slawekjaranowski force-pushed the doxia-2.x branch from dac9646 to ea84a01 Compare November 13, 2024 07:53

andrzejj0 approved these changes Nov 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Doxia 2.x stack #1180

Upgrade to Doxia 2.x stack #1180

slawekjaranowski commented Nov 9, 2024

andrzejj0 commented Nov 9, 2024 •

edited

Loading

michael-o commented Nov 9, 2024

michael-o left a comment

slawekjaranowski commented Nov 10, 2024

michael-o left a comment

michael-o Nov 12, 2024

slawekjaranowski Nov 12, 2024

andrzejj0 Nov 12, 2024

andrzejj0 Nov 12, 2024

slawekjaranowski Nov 12, 2024 •

edited

Loading

slawekjaranowski Nov 12, 2024

slawekjaranowski Nov 12, 2024

slawekjaranowski Nov 12, 2024

andrzejj0 Nov 13, 2024

slawekjaranowski Nov 13, 2024

andrzejj0 Nov 12, 2024

andrzejj0 Nov 12, 2024

andrzejj0 Nov 12, 2024

andrzejj0 Nov 13, 2024

slawekjaranowski commented Nov 13, 2024

andrzejj0 commented Nov 13, 2024

Upgrade to Doxia 2.x stack #1180

Are you sure you want to change the base?

Upgrade to Doxia 2.x stack #1180

Conversation

slawekjaranowski commented Nov 9, 2024

andrzejj0 commented Nov 9, 2024 • edited Loading

michael-o commented Nov 9, 2024

michael-o left a comment

Choose a reason for hiding this comment

slawekjaranowski commented Nov 10, 2024

michael-o left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slawekjaranowski Nov 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slawekjaranowski commented Nov 13, 2024

andrzejj0 commented Nov 13, 2024

andrzejj0 commented Nov 9, 2024 •

edited

Loading

slawekjaranowski Nov 12, 2024 •

edited

Loading