Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions Maven Plugin updates random Module subsets with 2.14.1 #858

Closed
jwachter opened this issue Dec 16, 2022 · 2 comments · Fixed by #859
Closed

Versions Maven Plugin updates random Module subsets with 2.14.1 #858

jwachter opened this issue Dec 16, 2022 · 2 comments · Fixed by #859
Labels
bug
Milestone
2.14.2

Comments

@jwachter
Copy link

Environment

  • Maven Multimodule Project with 295 Modules in a strict parent-child hierarchy
  • Maven Wrapper using Maven 3.8.6
  • Calling mvnw.cmd or ./mvnw with versions:set -DnewVersion=1.2.3-SNAPSHOT -DgenerateBackupPoms=false

Observed Behavior

On multiple runs it is not deterministic which versions are updated:

  • Run 1: 135 of 295 are not updated after BUILD SUCCESS (All children of a sub-parent)
  • Run 2: 0 of 295 are not updated after BUILD SUCCESS
  • Run 3: 3 of 295 are not updated after BUILD SUCCESS
  • Run 4: 138 of 295 are not updated after BUILD SUCCESS (Children in multiple disjoint sub-parent hierarchies)

One of the sub parent hierarchies that seems to be always involved (partially) when something is not updated contains a single level of ~140 children but still not always only that hierarchy or a specific number of the children is affected.

With 2.14.0 it seems to not be broken yet for the same amount of test runs.

As this seems somewhat like a typical race condition we suspect that the introduction of parallelStream in this line combined with a non-concurrent Map might be problematic: c74ced2#diff-f58ee99d4e29219ee1519ba59712674919933915a6485ab987093718d0b773dbR1359

Expected Behavior

All modules are consistently updated.
@andrzejj0
Copy link
Contributor

Thanks for the bug report. I think it's rather (files::add) which causes the problem in combination with parallelStream.

corebonts pushed a commit to corebonts/versions that referenced this issue Dec 16, 2022
mojohaus#858 Fix child module resolution for multi-level projects
aa88607 
Child modules were processed in a parallel stream which added elements to
an unsynchonized LinkedHashMap.

This may resulted an incomplete set of child modules.
corebonts pushed a commit to corebonts/versions that referenced this issue Dec 16, 2022
mojohaus#858 Fix child module resolution for multi-level projects
3e1ebcf 
Child modules were processed in a parallel stream which added elements to
an unsynchonized LinkedHashMap.

This may resulted an incomplete set of child modules.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Dec 16, 2022
@andrzejj0
Resolves mojohaus#858: Replacing parallelStream() with stream() where…
e379a6b 
… it mutates a non-thread safe collection
corebonts pushed a commit to corebonts/versions that referenced this issue Dec 16, 2022
mojohaus#858 Fix child module resolution for multi-level projects
9bf94d8 
Child modules were processed in a parallel stream which added elements to
an unsynchonized LinkedHashMap.

This may resulted an incomplete set of child modules.

Note that as the stream items are not processed heavily there is no or minor
advantage of parallel processing.
@andrzejj0
Copy link
Contributor

@corebonts there's also https://github.com/mojohaus/versions/blob/master/versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/SetMojo.java#L375

here, the non-thread safe collection is modified from within a parallel stream

please add that to your branch if you want

corebonts pushed a commit to corebonts/versions that referenced this issue Dec 16, 2022
mojohaus#858 Fix module resolution for multi-level projects
e4ee3be 
Modules were processed in a parallel stream which added elements to
an unsynchonized LinkedHashMap / LinkedHashSet.

This may resulted an incomplete set of child modules.

Note that as the stream items are not processed heavily there is no or minor
advantage of parallel processing.
@slawekjaranowski slawekjaranowski linked a pull request Dec 16, 2022 that will close this issue
#858 Fix child module resolution for multi-level projects #859
Merged
@slawekjaranowski slawekjaranowski added this to the next-release milestone Dec 16, 2022
slawekjaranowski pushed a commit that referenced this issue Dec 16, 2022
@slawekjaranowski
#858 Fix module resolution for multi-level projects
6619919 
Modules were processed in a parallel stream which added elements to
an unsynchonized LinkedHashMap / LinkedHashSet.

This may resulted an incomplete set of child modules.

Note that as the stream items are not processed heavily there is no or minor
advantage of parallel processing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.14.2
Development

Successfully merging a pull request may close this issue.

#858 Fix child module resolution for multi-level projects corebonts/versions
3 participants
@jwachter @andrzejj0 @slawekjaranowski