Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting valid versions comparison in case of qualifiers (alpha, beta, milestone, rc) #632

Closed
sultan opened this issue Aug 11, 2022 · 7 comments · Fixed by #672
Closed

Getting valid versions comparison in case of qualifiers (alpha, beta, milestone, rc) #632

sultan opened this issue Aug 11, 2022 · 7 comments · Fixed by #672
Labels
bug
Milestone
2.13.0

Comments

@sultan
Copy link
Contributor

sultan commented Aug 11, 2022 •
edited
Loading

image
image

In this exemple, we can se how RC versions are treated differently from non RC versions, however Activation APIs are from same 2.0 Major and should be treated as such
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 6, 2022
@sultan
mojohaus#632 Method parameters as SearchCriteria or SearchFlags objec…
ffa5fa9 
…t in order to prevent more than 7 parameters in methods. Preliminary work before fixing mojohaus#632.
@sultan
Copy link
Contributor Author

sultan commented Sep 7, 2022 •
edited
Loading

example of actual problem :

v3.0, searching next minor, creating upper and lower bounds
upper bound included v3.1
lower bound excluded v4.0

however versions v4.0 with qualifiers alpha, beta, rc lies before 4.0, this is an expected normal feature !

the problem is 4.0rc lies between 3.1 and 4.0 excluded and that 4.0rc is wrongly declared next minor of 3.1 when its a next major instead !
then the problem are the bounds creation that is not well designed

the bounds created should be 3.1snapshot and 4.0snapshot so that 4.0rc lies after 4.0snapshot and is next major instead of next minor

image

sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 7, 2022
@sultan
mojohaus#632 Fix Bounds so lower and upper bounds keep milestones and…
1b70f09 
… rcs in the same majors when they are. Preliminary work before fixing mojohaus#632.
@sultan sultan mentioned this issue Sep 7, 2022
Merged
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 14, 2022
@sultan
mojohaus#632 Fix Bounds so lower and upper bounds keep milestones and…
c779191 
… rcs in the same majors when they are. Preliminary work before fixing mojohaus#632.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 15, 2022
@sultan
mojohaus#632 Method parameters as Restriction in order to prevent mor…
18c608c 
…e than 7 parameters in methods in the next PRs.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 15, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
b1fde0a 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 16, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
01fd67d 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 16, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
c210ca2 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 16, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
c397535 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 16, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
c0ecc66 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 16, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
9b283b0 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 16, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
ada7f3b 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 16, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
9a0a4de 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 18, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
c2a23ed 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 18, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
2fc0d46 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 18, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
1c11ef6 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 18, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
6b7d3b8 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 18, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
ace04fa 
…in the right majors.
slawekjaranowski pushed a commit to sultan/versions-maven-plugin that referenced this issue Sep 18, 2022
@sultan @slawekjaranowski
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
4b81f62 
…in the right majors.
slawekjaranowski pushed a commit to sultan/versions-maven-plugin that referenced this issue Sep 18, 2022
@sultan @slawekjaranowski
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
0062205 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 19, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
510b66b 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 19, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
b0765ad 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 19, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
2413ee1 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 19, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
8c2ef6e 
…in the right majors.
sultan added a commit to sultan/versions-maven-plugin that referenced this issue Sep 19, 2022
@sultan
mojohaus#632 Fixed lower and upper bounds to keep milestones and rcs …
14e69b9 
…in the right majors.
@slawekjaranowski slawekjaranowski linked a pull request Sep 19, 2022 that will close this issue
#632 Fixed lower and upper bounds to keep milestones and rcs in the right majors. #672
Merged
@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Sep 19, 2022
slawekjaranowski pushed a commit that referenced this issue Sep 19, 2022
@sultan @slawekjaranowski
#632 Fixed lower and upper bounds to keep milestones and rcs in the r…
f0dc715 
…ight majors.
@sultan sultan mentioned this issue Sep 28, 2022
Merged
@sultan
Copy link
Contributor Author

sultan commented Oct 15, 2022 •
edited
Loading

Regression after infinity calculus PR ?

@sultan
Copy link
Contributor Author

sultan commented Oct 15, 2022

image

@sultan
Copy link
Contributor Author

sultan commented Oct 15, 2022 •
edited
Loading

non release versions are now ignored in summary but there in details

@sultan
Copy link
Contributor Author

sultan commented Oct 15, 2022

image

@sultan
Copy link
Contributor Author

sultan commented Oct 15, 2022

this leads to contradictory reports :
image

@andrzejj0
Copy link
Contributor

Created #760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.13.0
3 participants
@andrzejj0 @slawekjaranowski @sultan