Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

property-updates-report is slow with many dependencies & rules #575

Closed
TobiX opened this issue Mar 17, 2022 · 0 comments · Fixed by #647
Closed

property-updates-report is slow with many dependencies & rules #575

TobiX opened this issue Mar 17, 2022 · 0 comments · Fixed by #647

Comments

@TobiX
Copy link
Contributor

TobiX commented Mar 17, 2022

Not really sure why this happens, but when using a version rules file with the property-updates-report target, the report generation is very slow. I tried to implement a workaround in #365 (and added a reproducer today), since I wasn't able to track down the root cause of the issue... If someone has a better idea, I would be open to another approach.
@slawekjaranowski slawekjaranowski linked a pull request Aug 23, 2022 that will close this issue
Cache result of getBestFitRule (fixes #575) #647
Merged
slawekjaranowski pushed a commit that referenced this issue Aug 25, 2022
@TobiX @slawekjaranowski
Cache result of getBestFitRule (fixes #575)
6c6688b 
This was identified as a performance hotspot and the result is static
for each run, adding a cache dramatically speeds up some executions.

The included IT shows the problem: Without this optimization, it runs
over a minute, with the fix it finishes instantly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache result of getBestFitRule (fixes #575)
1 participant
@TobiX