-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different profile used for versions:set and versions:revert . #265
Comments
I get the exact same issue in one of my projects (writing this comment just to "bump" the issue). I think |
Looking into it. I know it's an old one. |
RevertMojo only recovers the old copy of the root pom.xml from the backup in the .versionsBackup file en relies on Maven itself to process all files in the reactor. This could indeed be enhanced. |
…ult maven processing
…ult maven processing
…ult maven processing
…ult maven processing
…ult maven processing
…ult maven processing
I have an aggregate POM situation that does not use inheritance, i.e the aggregated POMs do not have a parent-child relationship with the aggregating POM. The directory structure looks like this:
aggregate/
foo/
bar/
The aggregating POM in the
aggregate/
directory specifies thefoo
module:It also has a profile
foobar
which brings in thebar
module:Now here's the interesting part. If I go into the
aggregate/
directory and issue the following command:Thanks to the
processAllModules
option, this updates the aggregate POM version and the aggregated module versions both (bothfoo
andbar
, as well as there interdependent dependency references)! Yay!But if I then try to revert the changes:
This command does not revert the POM for the
bar
module!!! I have to specify thefoobar
profile to get it to be reverted too:One can make arguments either way about whether the plugin should automatically process modules that are part of profiles that weren't indicated, and for the purposes of this ticket it really doesn't matter.
The important thing is that: shouldn't both goals
versions:set
andversions:revert
use the same module inclusion rules for theprocessAllModules
option? Put another way, shouldn't I be able to use the same options I used for changing the version to commit or revert that version? I don't understand what different semantics ofprocessAllModules
would require me to indicate a profile for one of the goals but not the other.The text was updated successfully, but these errors were encountered: