Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goal: use-releases doesn't processes imported POMs in dependencyManagement #134

Closed
ghost opened this issue Mar 18, 2017 · 6 comments
Closed

Goal: use-releases doesn't processes imported POMs in dependencyManagement #134

ghost opened this issue Mar 18, 2017 · 6 comments
Assignees
@khmarbaise
Milestone
2.4

Comments

@ghost
Copy link

ghost commented Mar 18, 2017

The imported BOMs are not processed correctly by use-releases goal, the fix for #79 is not working either.
I suppose this is due to how maven resolves imported POMs - there is no separate dependency for such import, it's replaced by list of dependencies defined in the POM.
@ghost
Copy link
Author

ghost commented Mar 18, 2017

Pull Request created: #135

khmarbaise added a commit that referenced this issue Mar 18, 2017
@khmarbaise
Merge pull request #135 from akacme/master
045e52e 
Fix for #134: Goal: use-releases doesn't processes imported POMs in dependencyManagement
@khmarbaise khmarbaise added this to the 3.0.0 milestone Mar 18, 2017
@khmarbaise
Copy link
Member

Merged PR #135

@khmarbaise khmarbaise self-assigned this May 27, 2017
@andrzejj0
Copy link
Contributor

Does this also happen for other goals?

This was referenced Nov 10, 2022
Merged
Closed
@andrzejj0
Copy link
Contributor

I wanted to check if the same issue occurs in other Mojo's since they don't have that fix applied. It turns out that they don't suffer from the issue.

Further, when I removed the patch from UseReleasesMojo, import-scoped dependencies were still present in the collected dependency management dependencies, which means that they are now present out of the box and can be treated by the mojo. And the import dependencies get updated.

Which means that the patch can be removed. I'll create integration tests (important since Maven is involved) before doing that.

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 11, 2022
@andrzejj0
Removing the patch for mojohaus#134
b5af0f2
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 11, 2022
@andrzejj0
Added a mojohaus#134 test for UseLatestReleases
4a1d250
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 11, 2022
@andrzejj0
Added a mojohaus#134 test for UseLatestSnapshots
6394839
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 11, 2022
@andrzejj0
Added a mojohaus#134 test for UseNextReleasesMojo and UseNextSnapshot…
444e46a 
…sMojo
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 11, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed. Adding more…
29b4e8e 
… integration tests
@andrzejj0
Copy link
Contributor

Same issue: #25, #308, #309, #346, #395

@andrzejj0
Copy link
Contributor

So, this problem is typically resolved by using dependency management from raw model.

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 14, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
c250a38 
…etRawModel can be used instead. Adding more integration tests.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 14, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
95000ce 
…etRawModel can be used instead. Adding more integration tests.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 14, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
1a2bd50 
…etRawModel can be used instead. Adding more integration tests.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 14, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
e55ecd6 
…etRawModel can be used instead. Adding more integration tests.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 14, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
267ed55 
…etRawModel can be used instead. Adding more integration tests.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 14, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
8fe726e 
…etRawModel can be used instead. Adding more integration tests.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 17, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
16bba7c 
…etRawModel can be used instead. Adding more integration tests.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 19, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
34e2305 
…etRawModel can be used instead. Adding more integration tests.
andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Nov 19, 2022
@andrzejj0
Issue mojohaus#134: Removing the patch: no longer needed; PomHelper.g…
8fb889a 
…etRawModel can be used instead. Adding more integration tests.
slawekjaranowski pushed a commit that referenced this issue Nov 19, 2022
@andrzejj0 @slawekjaranowski
Issue #134: Removing the patch: no longer needed; PomHelper.getRawMod…
61c1f97 
…el can be used instead. Adding more integration tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khmarbaise khmarbaise

Labels
None yet
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
2 participants
@khmarbaise @andrzejj0