Skip to content

Commit

Permalink
Make includeParent false by default to retain backward compatibility.
Browse files Browse the repository at this point in the history
  • Loading branch information
andrzejj0 authored and slawekjaranowski committed Nov 19, 2022
1 parent 8230434 commit 02d88b8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,11 @@ public class DisplayPropertyUpdatesMojo
private boolean allowIncrementalUpdates;

/**
* <p>Whether to include property updates from parent.</p>
* <p>Whether to include property updates from parent. Default: {@code false}</p>
*
* @since 2.14.0
*/
@Parameter( property = "includeParent", defaultValue = "true" )
@Parameter( property = "includeParent", defaultValue = "false" )
protected boolean includeParent = true;

// -------------------------- STATIC METHODS --------------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ public class PropertyUpdatesReportMojo extends AbstractVersionsReport<PropertyUp
private boolean autoLinkItems;

/**
* <p>Whether to include property updates from parent.</p>
* <p>Whether to include property updates from parent. Default: {@code false}</p>
*
* @since 2.14.0
*/
@Parameter( property = "includeParent", defaultValue = "true" )
@Parameter( property = "includeParent", defaultValue = "false" )
private boolean includeParent = true;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public void testPropertiesFromParent() throws Exception
mojo.outputFile = tempFile.toFile();
mojo.setPluginContext( new HashMap<>() );
mojo.artifactMetadataSource = MockUtils.mockArtifactMetadataSource();
mojo.includeParent = true;
mojo.execute();

assertThat( String.join( "", Files.readAllLines( tempFile ) ),
Expand Down

0 comments on commit 02d88b8

Please sign in to comment.