Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making timestamp deserialization consistent #18

Merged
merged 2 commits into from
Sep 28, 2017
Merged

making timestamp deserialization consistent #18

merged 2 commits into from
Sep 28, 2017

Conversation

or-shachar
Copy link
Contributor

fixing #17

@or-shachar
Copy link
Contributor Author

or-shachar commented Sep 13, 2017 •
edited
Loading

Not sure the failure is related to my change.
travis-ci/travis-ci#7884 (comment)

@or-shachar
Copy link
Contributor Author

Hi @khmarbaise . Appreciate your review.
Thanks!

@or-shachar
Copy link
Contributor Author

or-shachar commented Sep 26, 2017 •
edited
Loading

@rfscholte @stephenc , maybe you can help here?

@rfscholte
Copy link
Member

With a quick view this fix seems okay, would be nice if this could be confirmed with a unittest

@stephenc
Copy link
Contributor

stephenc commented Sep 27, 2017 via email

@rfscholte rfscholte merged commit efbe996 into mojohaus:master Sep 28, 2017
@rfscholte rfscholte added this to the 3.0.0 milestone Sep 28, 2017
@rfscholte rfscholte self-assigned this Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rfscholte rfscholte

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@or-shachar @rfscholte @stephenc