Enhance exception handling for license execution when the URL tag of …

…the license is empty.
mojohaus · Sep 11, 2024 · a331569 · a331569
1 parent 9ad7c7a
commit a331569
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java b/src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java
@@ -47,6 +47,7 @@
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.lang.StringEscapeUtils;
+import org.apache.commons.lang.StringUtils;
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.plugin.MojoExecutionException;
 import org.apache.maven.plugin.MojoFailureException;
@@ -1276,11 +1277,11 @@ private void downloadLicenses(
 
         int licenseIndex = 0;
         for (ProjectLicense license : licenses) {
-            if (matchingUrlsOnly && license.getUrl() == null) {
+            if (matchingUrlsOnly && StringUtils.isBlank(license.getUrl())) {
                 handleError(
                         depProject,
                         "No URL for license at index " + licenseIndex + " in dependency " + depProject.toGavString());
-            } else if (license.getUrl() != null) {
+            } else if (StringUtils.isNotBlank(license.getUrl())) {
                 final String licenseUrl = urlReplacements.rewriteIfNecessary(license.getUrl());
 
                 final LicenseDownloadResult cachedResult = cache.get(licenseUrl);