Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize JDK 24 #308

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

@cstamas
Copy link

cstamas commented Sep 19, 2024

LGTM

@slawekjaranowski @gnodet

@slawekjaranowski slawekjaranowski merged commit a5b2a00 into mojohaus:master Sep 19, 2024
20 checks passed
@mbien
Copy link

mbien commented Sep 19, 2024

static String renderVersion(int major, int minor) {
if (minor == 0) {
for (Map.Entry<String, Integer> entry : JDK_TO_MAJOR_VERSION_NUMBER_MAPPING.entrySet()) {
if (major == entry.getValue()) {
return "JDK " + entry.getKey();

is going to fail once JDK 45 is released :D

@wendigo wendigo deleted the serafin/jdk24-recognize branch September 19, 2024 11:00
@wendigo
Copy link
Contributor Author

wendigo commented Sep 19, 2024

@mbien I will be retired by then (at least I hope so) ;)

@wendigo
Copy link
Contributor Author

wendigo commented Sep 19, 2024

@mbien and if the Valhalla is delivered before that, this should work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants