Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow genjava to install to local maven #2

Merged
merged 2 commits into from
Sep 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion cmake/genjava-catkin-api.cmake.em
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,35 @@ macro(generate_rosjava_messages)
message(FATAL_ERROR "generate_rosjava_messages() called with unused arguments: ${ARG_UNPARSED_ARGUMENTS}")
endif()
catkin_rosjava_env_setup()
message(STATUS "ROS_GRADLE_VERBOSE: ${ROS_GRADLE_VERBOSE}")
message(STATUS "ROS_MAVEN_DEPLOYMENT_REPOSITORY: ${ROS_MAVEN_DEPLOYMENT_REPOSITORY}")
message(STATUS "ROS_MAVEN_REPOSITORY: ${ROS_MAVEN_REPOSITORY}")
message(STATUS "GRADLE_USER_HOME: ${GRADLE_USER_HOME}")
set(ROS_GRADLE_VERBOSE $ENV{ROS_GRADLE_VERBOSE})
if(ROS_GRADLE_VERBOSE)
set(verbosity "--verbosity")
else()
set(verbosity "")
endif()
set(avoid_rebuilding "")
#set(avoid_rebuilding "--avoid-rebuilding")
string(REPLACE ";" " " package_list "${ARG_PACKAGES}")

message(STATUS "#### ${PROJECT_NAME}_generate_artifacts ####")
message(STATUS "PROJECT_NAME: ${PROJECT_NAME}")
message(STATUS "CATKIN_ENV: ${CATKIN_ENV}")
message(STATUS "PYTHON_EXECUTABLE: ${PYTHON_EXECUTABLE}")
message(STATUS "GENJAVA_MESSAGE_ARTIFACTS_BIN: ${GENJAVA_MESSAGE_ARTIFACTS_BIN}")
message(STATUS "verbosity: ${verbosity}")
message(STATUS "avoid_rebuilding: ${avoid_rebuilding}")
message(STATUS "CMAKE_CURRENT_BINARY_DIR: ${CMAKE_CURRENT_BINARY_DIR}")
message(STATUS "ARG_PACKAGES: ${ARG_PACKAGES}")
message(STATUS "package_list: ${package_list}")
add_custom_target(${PROJECT_NAME}_generate_artifacts
ALL
COMMAND ${CATKIN_ENV} ${PYTHON_EXECUTABLE} ${GENJAVA_MESSAGE_ARTIFACTS_BIN}
${verbosity}
--avoid-rebuilding
${avoid_rebuilding}
-o ${CMAKE_CURRENT_BINARY_DIR}
-p ${ARG_PACKAGES} # this has to be a list argument so it separates each arg (not a single string!)
DEPENDS
Expand Down
8 changes: 4 additions & 4 deletions src/genjava/genjava_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def main(argv):
changed and so forth.
'''
args = parse_arguments(argv[1:])
#print("genjava %s/%s" % (args.package, args.message))
print("genjava.main %s" % (args))
if not args.compile:
gradle_project.create(args.package, args.output_dir)
else:
Expand All @@ -88,7 +88,7 @@ def standalone_parse_arguments(argv):
parser = argparse.ArgumentParser(description='Generate artifacts for any/all discoverable message packages.')
parser.add_argument('-p', '--packages', action='store', nargs='*', default=[], help='a list of packages to generate artifacts for')
parser.add_argument('-o', '--output-dir', action='store', default='build', help='output directory for the java code (e.g. build/foo_msgs)')
parser.add_argument('-v', '--verbose', default=False, action='store_true', help='enable verbosity in debugging (false)')
parser.add_argument('-v', '--verbosity', default=False, action='store_true', help='enable verbosity in debugging (false)')
parser.add_argument('-f', '--fakeit', default=False, action='store_true', help='dont build, just list the packages it would build (false)')
parser.add_argument('-a', '--avoid-rebuilding', default=False, action='store_true', help='avoid rebuilding if the working directory is already present (false)')
parsed_arguments = parser.parse_args(argv)
Expand All @@ -102,7 +102,7 @@ def standalone_main(argv):
generate artifacts for.
'''
args = standalone_parse_arguments(argv[1:])
#print("genjava %s/%s/%s" % (args.package, args.output_dir, args.verbose))
print("genjava.standalone_main %s" % (args))

sorted_package_tuples = rosjava_build_tools.catkin.index_message_package_dependencies_from_local_environment(package_name_list=args.packages)

Expand All @@ -111,7 +111,7 @@ def standalone_main(argv):
did_not_rebuild_these_packages = []
if not args.fakeit:
for unused_relative_path, p in sorted_package_tuples:
result = gradle_project.standalone_create_and_build(p.name, args.output_dir, args.verbose, args.avoid_rebuilding)
result = gradle_project.standalone_create_and_build(p.name, args.output_dir, args.verbosity, args.avoid_rebuilding)
if not result:
did_not_rebuild_these_packages.append(p.name)
if did_not_rebuild_these_packages:
Expand Down
5 changes: 3 additions & 2 deletions src/genjava/gradle_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ def create(msg_pkg_name, output_dir):
raise IOError("could not find %s among message packages. Does the that package have a <build_depend> on message_generation in its package.xml?" % msg_pkg_name)

msg_dependencies = create_dependency_string(msg_pkg_name, msg_package_index)
print("msg_dependencies: %s" %msg_dependencies)

create_gradle_wrapper(genjava_gradle_dir)
pkg_directory = os.path.abspath(os.path.dirname(msg_package_index[msg_pkg_name].filename))
Expand All @@ -171,7 +172,7 @@ def build(msg_pkg_name, output_dir, verbosity):
cmd = ['./gradlew']
if not verbosity:
cmd.append('--quiet')
#print("COMMAND........................%s" % cmd)
print("COMMAND build ........................%s" % cmd)
subprocess.call(cmd, stderr=subprocess.STDOUT,)


Expand All @@ -195,6 +196,6 @@ def standalone_create_and_build(msg_pkg_name, output_dir, verbosity, avoid_rebui
cmd = [gradle_wrapper, '-p', working_directory]
if not verbosity:
cmd.append('--quiet')
#print("COMMAND........................%s" % cmd)
print("COMMAND standalone_create_and_build ........................%s" % cmd)
subprocess.call(cmd, stderr=subprocess.STDOUT,)
return True
2 changes: 1 addition & 1 deletion src/genjava/templates/genjava_project/build.gradle.in
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,4 @@ task bugfixtask {

jar.dependsOn(bugfixtask)

defaultTasks 'publish'
defaultTasks 'publish', 'install', 'info'