Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added custom dumper for pm4ml merge function #202

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

vijayg10
Copy link
Contributor

In custom_config/pm4ml-vars.yaml, if we pass the following values

core_connector_config:
  enabled: true
  env:
    TEST1_ID: '0720'
    TEST1_PREFIX: '00002893'
The value '0720' is passing to the generated helm values file correctly but the value '00002893' is being transformed as an integer without preceding zeros like 2893

Solution:
Added a custom dumper that works with yaml.dump function
Some explanation about this issue is here
yaml/pyyaml#98 (comment)
A leading zero in YAML 1.1 indicates an octal number, which can only have digits 0-7

@vijayg10 vijayg10 requested a review from sijo5722-2021 March 27, 2024 13:08
@vijayg10 vijayg10 self-assigned this Mar 27, 2024
Copy link
Collaborator

@sijo5722-2021 sijo5722-2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vijayg10 vijayg10 merged commit 11d0a41 into main Mar 27, 2024
1 check passed
@vijayg10 vijayg10 deleted the fix/yaml-dumper branch March 27, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants