Skip to content

Conversation

@shenoyvvarun
Copy link
Contributor

Signed-off-by: Alexandre Milesi <[email protected]>
Co-authored-by: Alexandre Milesi <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks two bug fixes related to the multimodal profiler. The core change correctly calculates the maximum number of tokens for multimodal inputs by including non-embedding tokens, which is a crucial fix for accurate memory profiling. A new test case for mllama4 has been added to verify this new logic.

The changes are generally well-implemented, but I've identified a critical issue: a leftover merge conflict marker that will break the build. Additionally, there's a missing return type hint in a new public method, which should be addressed to maintain code quality.

Once these issues are resolved, the pull request should be in good shape.

@shenoyvvarun shenoyvvarun force-pushed the vasheno/profiler-bug-fix3 branch from 2f12e79 to 61dcb28 Compare July 30, 2025 20:58
@shenoyvvarun shenoyvvarun merged commit 7c4c2e9 into feature-based-on-v0.9.1 Jul 31, 2025
0 of 2 checks passed
@shenoyvvarun shenoyvvarun deleted the vasheno/profiler-bug-fix3 branch July 31, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants