Skip to content

Conversation

@shenoyvvarun
Copy link
Contributor

@shenoyvvarun shenoyvvarun commented Jul 29, 2025

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in the MultiModalProfiler where the token budget for multimodal inputs was underestimated, potentially causing requests with large images to hang. The fix correctly calculates the token budget by considering the total length of multimodal placeholders, including bookkeeping tokens, instead of only counting embeddable tokens.

The changes are logical and directly address the issue described. A comprehensive new test for the mllama4 model has been added, which validates the fix by comparing the profiler's output against a manually calculated token count. The supporting changes in the model registry are appropriate.

@CatherineSue
Copy link
Contributor

What is the comment in the vLLM PR about? vllm-project/vllm#21842 (comment)

@YouNeedCryDear
Copy link

What is the comment in the vLLM PR about? vllm-project/vllm#21842 (comment)

This one I think vllm-project/vllm#21798 (review)

@upfixer
Copy link

upfixer commented Jul 30, 2025

vllm-project/vllm#21798 (review)
since that pr is merged, cherry-pick that and add tests?

@shenoyvvarun
Copy link
Contributor Author

What is the comment in the vLLM PR about? vllm-project/vllm#21842 (comment)
This about the other PR referenced.

vllm-project/vllm#21798 (review) since Both PR is merged. I added cherry picks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants