Skip to content

Add set_custom_ffprobe_path method to ffprobe#13

Closed
moi15moi wants to merge 2 commits intomainfrom
be-able-set-ffprobe-path
Closed

Add set_custom_ffprobe_path method to ffprobe#13
moi15moi wants to merge 2 commits intomainfrom
be-able-set-ffprobe-path

Conversation

@moi15moi
Copy link
Owner

@moi15moi moi15moi commented May 5, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.50%. Comparing base (5fa88d0) to head (744a25c).

Files with missing lines Patch % Lines
video_timestamps/ffprobe/ffprobe.py 81.25% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   97.54%   97.50%   -0.04%     
==========================================
  Files          18       18              
  Lines        1586     1604      +18     
==========================================
+ Hits         1547     1564      +17     
- Misses         39       40       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moi15moi moi15moi force-pushed the be-able-set-ffprobe-path branch from a6e0c0a to ee345c7 Compare May 5, 2025 23:27
@moi15moi moi15moi force-pushed the be-able-set-ffprobe-path branch from f4f26dd to 744a25c Compare May 5, 2025 23:53
@moi15moi
Copy link
Owner Author

We don't use ffprobe anymore (because of #14), so we don't need to PR anymore. Let's close it.

@moi15moi moi15moi closed this Oct 26, 2025
@moi15moi moi15moi deleted the be-able-set-ffprobe-path branch October 26, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments