Add release hygiene, CI, and trusted publishing - #42
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe repository adds npm package metadata and artifact validation, CI and trusted publishing workflows, security and contribution policies, structured issue and pull-request templates, Dependabot configuration, and tests covering package, workflow, and repository release contracts. ChangesRelease and repository governance
Estimated code review effort: 4 (Complex) | ~60 minutes Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (2 errors)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/pull_request_template.md:
- Line 1: Add a top-level H1 heading before the existing “## Summary” heading in
the pull request template, ensuring the document follows a valid Markdown
heading hierarchy and satisfies markdownlint MD041.
In @.github/workflows/publish.yml:
- Around line 35-59: Review the npm version comparison in the inline toolchain
check and simplify the convoluted nested every/some logic into a clearer
tuple-wise comparison while preserving the existing behavior for versions such
as 12.0.0, 11.5.1, 11.5.0, 11.4.9, and 10.9.9. Keep the validation and error
handling in the “Verify trusted-publishing toolchain” step unchanged.
In `@SECURITY.md`:
- Line 11: Verify that GitHub private vulnerability reporting is enabled for the
repository, and test the security advisory link to confirm it opens a valid
private disclosure form before release. Update the guidance if necessary so
vulnerability details are not submitted publicly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6f2b3f2c-0101-47b6-900c-0a295520568e
📒 Files selected for processing (15)
.github/ISSUE_TEMPLATE/bug_report.yml.github/ISSUE_TEMPLATE/config.yml.github/ISSUE_TEMPLATE/feature_request.yml.github/dependabot.yml.github/pull_request_template.md.github/workflows/ci.yml.github/workflows/publish.ymlCHANGELOG.mdCONTRIBUTING.mdREADME.mdSECURITY.mdpackage.jsonscripts/check-pack.mjstests/package-contract.test.tstests/release-config.test.ts
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/release-config.test.ts`:
- Around line 16-22: Move the regex literals used by npmVersionComparison and
the callback around lines 96–114 to module-level constants, then reference those
static constants inside the function and callback. Preserve the existing
patterns and matching behavior while eliminating the e18e/prefer-static-regex
lint violations.
In `@tests/tooling-config.test.ts`:
- Around line 9-31: Move the regex literals used in the three tests in
tooling-config.test.ts to module-level constants, then reference those constants
inside the expect(...).toMatch calls to satisfy e18e/prefer-static-regex while
preserving the existing matching behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d0d2a701-2f2d-4274-8a5f-adf66619ce5b
📒 Files selected for processing (6)
.github/pull_request_template.md.github/workflows/publish.ymleslint.config.jsscripts/check-pack.mjstests/release-config.test.tstests/tooling-config.test.ts
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Linked issue
Validation
Summary by CodeRabbit
New Features
Documentation
Tests