Release v1.1.1 - #401
Conversation
Fix Claude tool schema compatibility
chore: prepare v1.1.1 release
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe release updates Miftah to ChangesSchema Compatibility Release
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant MiftahServer
participant AuditFlow
Client->>MiftahServer: Request tools/list
MiftahServer->>AuditFlow: Run audit with schema-aware redactor
AuditFlow-->>MiftahServer: Return redacted tool catalog
MiftahServer-->>Client: Return preserved schemas and redacted metadata
Possibly related issues
Possibly related PRs
Suggested labels: Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 56: README.md lines 56-56: do not expose the 1.1.1 install command until
1.1.1 is published from the exact current main commit and registry and
provenance verification is complete; otherwise retain the last published
version. Apply the same publication gate to docs/whats-new-in-0.5.md lines 3-6,
keeping both version references consistent.
In `@src/mcp/server/miftah-server.ts`:
- Around line 3714-3719: Update redactClientVisibleSchema and the related
literal-object redaction path in src/mcp/server/miftah-server.ts#L3714-L3719 and
`#L3751-L3753` to generate stable unique aliases for colliding redacted keys,
preserving every entry and applying the same aliases to dependent references;
add two sensitive keys to the properties fixture in
tests/fixtures/fake-upstream-runtime.mjs#L389-L413 and assert both redacted
property definitions remain present in tests/mcp-wrapper.test.ts#L3897-L3913.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7a202386-024e-4162-afc3-40dc753a9ae4
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (13)
CHANGELOG.mdREADME.mddocs/mcp-compatibility.mddocs/presets-and-clients.mddocs/whats-new-in-0.5.mdpackage.jsonsrc/mcp/server/miftah-server.tstests/authenticated-request-context-docs-contract.test.tstests/fixtures/fake-upstream-bundled.mjstests/fixtures/fake-upstream-runtime.mjstests/mcp-wrapper.test.tstests/profile-context-handle-docs-contract.test.tstests/release-version.test.ts
Fix schema redaction alias collisions
|
@coderabbitai review |
✅ Action performedReview finished.
|
The major collision finding is fixed and CodeRabbit confirmed it addressed on head 1b5e306. The remaining publication-sequencing note is intentionally handled by the protected exact-main GitHub Release workflow and its thread is resolved with rationale.
Sync main into development for v1.1.1 promotion
|
@coderabbitai review |
|
Release promotion
Promote the exact finalized
developmentcommite43f8abc0c237aa8492478e323e80d70cc35177dtomainfor v1.1.1.Included change
trueto equivalent{}while retainingfalseSecurity impact
The release closes a schema-catalog credential exposure gap identified during review: actual secret/token text used as a schema object key is now redacted before client exposure. Existing structured secret redaction, routing policy, audit, containment, OAuth, and public API contracts remain unchanged.
Evidence
Publication boundary
Merging this PR does not publish. After exact-main CI passes, create GitHub Release
v1.1.1at the exact currentmaincommit; that protected Release event is the only npm trusted-publishing trigger. Never run workstationnpm publish.Tracks #399.
Summary by CodeRabbit