chore(release): prepare v1.0.0 - #374
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughMiftah moves from version 0.5.8 to stable 1.0.0. The change updates Semantic Versioning policies, release and validation documentation, security dependency overrides, and contract tests for patched packages and release evidence. ChangesStable release preparation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/independent-security-review.md`:
- Around line 11-13: Update the recorded review status near the existing
maintainer-attestation text in docs/independent-security-review.md (lines 11-13)
to explicitly state that attestation or deidentified records cannot close the
independent-review gate or issue `#39`; in docs/v1-evaluation.md (line 138),
require complete linked records and accepted closure gates before replacing
pending rows with completion evidence.
In `@docs/oauth-console-validation.md`:
- Around line 40-51: Update docs/oauth-console-validation.md lines 40-51 to
describe OAuth and Console as included in the 1.0.0 release candidate, not as a
stable release, while preserving the maintainer-attested external evidence
qualification. Update docs/oauth-console-validation.md line 3 to replace
“external-evidence status was accepted” with precise attestation wording. Extend
tests/v1-readiness-docs-contract.test.ts lines 67-81 with exact candidate-status
assertions and negative checks rejecting unqualified stable-release claims.
In `@docs/v1-evaluation.md`:
- Around line 5-7: The evaluation guide at docs/v1-evaluation.md lines 5-7 must
bind attested readiness evidence to `@lubab/miftah`@1.0.0, or clearly separate
baseline and candidate results; do not combine evidence across versions without
the documented delta assessment. Update tests/v1-readiness-docs-contract.test.ts
lines 25-27 to require the guide to contain the exact packageVersion candidate
string.
In `@package.json`:
- Line 3: Do not merge the release metadata change in package.json until the
final development head has passing required CI and the necessary review
approval. Before promotion, ensure the package version, lockfile, changelog, and
documented release checks are finalized.
In `@tests/readme-product-contract.test.ts`:
- Around line 64-67: Update the assertions in
tests/readme-product-contract.test.ts:64-67 to verify the documentation states
that source participant records and the completed security report are not
published in the repository. Also update
tests/v050-feature-guide-contract.test.ts:105-107 to verify that underlying
participant records are not published; both sites require direct assertion
changes alongside their existing maintainer-attestation checks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: db8d49b7-22a4-4d87-bbc2-59d024409f67
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (21)
CHANGELOG.mdREADME.mddocs/cli.mddocs/config.mddocs/independent-security-review.mddocs/library-api.mddocs/oauth-console-validation.mddocs/plugins.mddocs/presets-and-clients.mddocs/threat-model.mddocs/v1-evaluation.mddocs/whats-new-in-0.5.mdpackage.jsontests/fixtures/fake-upstream-bundled.mjstests/oauth-console-validation-contract.test.tstests/package-contract.test.tstests/readme-product-contract.test.tstests/release-config.test.tstests/release-version.test.tstests/v050-feature-guide-contract.test.tstests/v1-readiness-docs-contract.test.ts
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/oauth-console-validation.md (1)
44-51: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winKeep the external-evidence version boundary consistent.
The v1 evaluation protocol limits the attested counters to the
0.5.8baseline, but the OAuth/Console page and its contract test do not enforce that boundary.
docs/oauth-console-validation.md#L44-L51: State that the 5/3/3 counters apply only to the0.5.8baseline.tests/v1-readiness-docs-contract.test.ts#L89-L97: Assert the baseline-only wording.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/oauth-console-validation.md` around lines 44 - 51, Update docs/oauth-console-validation.md to explicitly state that the 5/3/3 attested counters apply only to the `@lubab/miftah`@0.5.8 evaluator baseline, not the 1.0.0 release candidate. Update tests/v1-readiness-docs-contract.test.ts to assert this baseline-only wording.
♻️ Duplicate comments (1)
tests/readme-product-contract.test.ts (1)
66-68: 🔒 Security & Privacy | 🟡 MinorInclude the repository scope in the assertion.
The required disclosure states that the records are not published in this repository. This assertion stops before that scope, so a weaker statement could still pass. Match the complete README phrase.
Proposed fix
expect(firstScreen).toContain( - "source participant records and completed security report are not published", + "source participant records and completed security report are not published in this repository", );🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/readme-product-contract.test.ts` around lines 66 - 68, Update the firstScreen assertion in readme-product-contract.test.ts to match the complete README disclosure phrase, including the repository scope “in this repository” after “are not published.”
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/oauth-console-validation.md`:
- Around line 44-51: Update docs/oauth-console-validation.md to explicitly state
that the 5/3/3 attested counters apply only to the `@lubab/miftah`@0.5.8 evaluator
baseline, not the 1.0.0 release candidate. Update
tests/v1-readiness-docs-contract.test.ts to assert this baseline-only wording.
---
Duplicate comments:
In `@tests/readme-product-contract.test.ts`:
- Around line 66-68: Update the firstScreen assertion in
readme-product-contract.test.ts to match the complete README disclosure phrase,
including the repository scope “in this repository” after “are not published.”
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 360577b9-0961-4e01-a84f-c47a7303d1fd
📒 Files selected for processing (6)
docs/independent-security-review.mddocs/oauth-console-validation.mddocs/v1-evaluation.mdtests/readme-product-contract.test.tstests/v050-feature-guide-contract.test.tstests/v1-readiness-docs-contract.test.ts
Owner
Author
|
Incremental review follow-up is addressed in b4d942c:
Local release-document contracts pass 56/56 and lint is clean. Fresh exact-head CI is https://github.com/mohanagy/miftah/actions/runs/31457897932. |
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@lubab/miftah@1.0.0package and lockfile metadata;Evidence boundary
The maintainer reported 5/5 completed external workflows, 3 returning participants, 3 unaided evaluators, and a completed security report, and explicitly authorized closure of the related issues. The participant records and completed report were not independently inspected in this release-preparation session. Documentation and changelog text preserve that distinction. This PR does not independently assert provider coverage, reviewer attribution, severity counts, remediation, or final-candidate delta acceptance.
Security refresh
fast-uri3.1.5ip-address10.3.1hono4.12.34brace-expansion5.0.9nanoid3.3.17Both
npm audit --omit=devand fullnpm auditreport zero vulnerabilities.Validation
npm run test:core: 429 passed; 26 skipped;npm run test:coverage: 1,847 passed; 34 skipped; 95.67% statements;npm audit --omit=dev;npm audit;git diff --check.The final release still requires exact-head protected CI on
development, reviewed promotion tomain, an exact-mainv1.0.0GitHub Release, protected OIDC publication, registry provenance, fresh-install verification, and signature verification before #39 can close.Refs #373.
Refs #39.
Summary by CodeRabbit
New Features
@lubab/miftah@1.0.0.Security
Documentation