feat(console): focus management task sections - #336
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Console workspace now uses five focused task panels: Overview, Accounts, Authentication, Client setup, and Audit. Tabs support ARIA state, keyboard navigation, URL-hash restoration, draft preservation, and session-resume initialization. Tests cover these behaviors. ChangesConsole task navigation
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant WorkspaceNavigation
participant WorkspacePanels
Browser->>WorkspaceNavigation: Click tab or press navigation key
WorkspaceNavigation->>Browser: Update URL hash and focus tab
WorkspaceNavigation->>WorkspacePanels: Select one panel and hide others
Browser->>WorkspaceNavigation: Trigger hashchange or startup
WorkspaceNavigation->>WorkspacePanels: Restore valid panel selection
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/console-server.test.ts`:
- Around line 1617-1619: Update the workspace navigation stub in
exerciseSessionResumeLifecycle to record each
initializeWorkspaceTaskNavigation() invocation, return that count from the
helper, and assert the expected initialization count in the session-resume
lifecycle test. Ensure the assertion verifies navigation initialization still
occurs during reauthentication and hash-based task restoration.
- Around line 134-141: Extend exerciseWorkspaceTaskNavigation to expose each
task tab’s aria-selected and tabindex state, then execute the ArrowLeft path
alongside the existing navigation actions. Update the related assertions to
verify after every task change that exactly one tab is selected and exactly one
is focusable, including the state after left navigation and restoration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 967758c3-f2c6-49e8-84df-e9218785211f
📒 Files selected for processing (3)
CHANGELOG.mdsrc/console/console-assets.tstests/console-server.test.ts
1 participant
Closes #332
Summary
Safety boundaries
Navigation changes only visibility, ARIA state, focus, and the URL fragment. It does not call an API, reset a form, write configuration, or alter redaction, audit, OAuth, containment, subprocess, Windows, or public API behavior.
Validation
npm test— 1,822 passed, 33 platform skipsnpm run test:core— 426 passed, 26 platform skipsnpm run test:coverage -- --maxWorkers=1 --maxConcurrency=1— 1,822 passed, 33 platform skips; thresholds passed at 95.67% statements and 91.92% branchesnpm run lintnpm run typechecknpm run buildnpm run smoke:clinpm run check:pack— 48 files verifiednpm run test:package— 26 passedTwo earlier full-suite attempts exposed unchanged fixed-window process/cancellation tests under local load. Each exact test passed unchanged in isolation, and the final normal and serialized coverage runs passed without timeout changes.
Summary by CodeRabbit