Console: lead with connections and named accounts - #318
Conversation
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe Console now shows named profiles, durable defaults, and MCP profile-switching capability. It separates active-session status from durable configuration changes, collapses authentication guidance, and adds tests for catalog metadata and dashboard ordering. ChangesConsole profile discovery and switching
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant ConsoleUI
participant ConfigurationCatalog
participant ActiveMCP
User->>ConsoleUI: Open configuration catalog
ConsoleUI->>ConfigurationCatalog: Read profile names and switching capability
ConfigurationCatalog-->>ConsoleUI: Return catalog metadata
User->>ConsoleUI: Select profile or save durable default
ConsoleUI->>ActiveMCP: Switch active profile when supported
ActiveMCP-->>ConsoleUI: Return session status
Possibly related issues
Possibly related PRs
Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review The PR description now follows the repository template, includes the full security impact and exact validation results, and explicitly scopes this as the technical Console slice of #202 while leaving the three-external-evaluator gate open. |
|
✅ Action performedReview finished.
|
Summary
miftah_use_profileis availableScope
This PR is the focused Console implementation slice of #202. It does not claim to complete the broader external-validation acceptance criterion. Issue #202 remains open for evidence that three external evaluators can use the flow unaided; no issue auto-close keyword is used.
Security impact
allowProfileSwitchingFromMcpsetting enablesmiftah_use_profile; it does not change routing, active sessions, durable defaults, confirmation requirements, or policy enforcement.TDD evidence
Validation
npm run lint— passednpm run typecheck— passednpm test— 1,808 passed, 33 skipped by existing platform conditionsnpm run test:core— 425 passed, 26 skipped by existing platform conditionsnpm run test:coverage— 95.65% statements, 91.92% branches, 98.66% functions, 95.65% linesnpm run build— passednode dist/cli/main.js schemavianpm run smoke:cli— passednpm run check:pack— package contract verified, 48 filesnpm run test:package— 26 passed, including real tarball install and binary executionnpm audit --audit-level=moderate— 0 vulnerabilitiesCHANGELOG.mdare updated when applicable.CHANGELOG.mdrecords the Console change and keeps external validation explicitly incomplete.Refs #202