Skip to content

release: prepare v0.5.4 - #315

Merged
mohanagy merged 2 commits into
developmentfrom
release/0.5.4
Jul 30, 2026
Merged

release: prepare v0.5.4#315
mohanagy merged 2 commits into
developmentfrom
release/0.5.4

Conversation

@mohanagy

@mohanagy mohanagy commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

Refs #314

Validation

  • focused release/docs contracts: 53 passed
  • npm run test:core: 425 passed, 26 platform skips
  • npm run test:coverage: 1,807 passed, 33 platform skips; 95.65% statements, 91.89% branches
  • npm run lint
  • npm run typecheck
  • npm run build
  • npm run smoke:cli
  • npm run check:pack
  • npm run test:package: 26 passed
  • exact merged development CI run 30576782992: green after one unchanged Windows Node 20 retry

Local timing note

Plain npm test was run three times on the local macOS worktree. Each aggregate run passed more than 1,800 tests but hit a different existing load-sensitive 1-second startup or 5-second test bound. Every reported test passed when rerun in isolation, and the identical full suite passed under npm run test:coverage; no timeout or runtime code was changed. Current-head Linux/macOS/Windows CI remains required before merge.

Summary by CodeRabbit

  • New Features

    • Improved returning-user setup guidance so only one setup path is shown at a time.
    • Back returns to the setup chooser, while Cancel clears the draft without changing configuration.
    • Existing local STDIO and provider-managed account flows remain supported.
  • Documentation

    • Updated installation instructions and onboarding references for release 0.5.4.
    • Added release notes describing the guided setup improvements.
  • Chores

    • Published version 0.5.4 and updated release validation.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The release is bumped from 0.5.3 to 0.5.4 across package metadata, installation documentation, changelog content, and release-version tests. Tests also validate updated returning-user Console setup wording and issue references.

Changes

Miftah 0.5.4 release preparation

Layer / File(s) Summary
Release metadata and documentation
package.json, CHANGELOG.md, README.md, docs/...
The package version, changelog entry, and documented installation commands are updated from 0.5.3 to 0.5.4.
Release artifact validation
tests/release-version.test.ts
Release fixtures and assertions target 0.5.4 and verify the updated changelog issue reference and Console setup text.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

  • mohanagy/miftah#310 — Updates the same 0.5.3-to-0.5.4 release machinery and guided Console changelog expectations.
  • mohanagy/miftah#306 — Updates matching release-version tests, changelog references, and version documentation.
  • mohanagy/miftah#45 — Provides a structurally similar release-version and artifact validation update.

Poem

A bunny bumps the version bright,
From five-three to five-four tonight.
The changelog sings, the tests agree,
“Back” and “Cancel” keep drafts free.
Hop, hop—release notes bloom with glee!


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Docstring Coverage ❌ Error Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description includes Summary and Validation, but it omits the required Security impact section from the template. Add a Security impact section, even if it is just “none” after reviewing the affected boundaries.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title concisely reflects the main change: preparing the v0.5.4 release.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/0.5.4

Comment @coderabbitai help to get the list of available commands.

@mohanagy

Copy link
Copy Markdown
Owner Author

Review note: CodeRabbit did not perform a substantive review because its comment reports a temporary fair-usage rate limit. Its successful status is not being treated as approval. An independent exact-head review is in progress and will be recorded before merge.

Current-head CI run 30578276442 is green after one unchanged Windows Node 24 retry; the initial failure was a single existing 5-second test timeout, with no assertion failure and no source or timeout change.

@mohanagy

Copy link
Copy Markdown
Owner Author

Independent review finding addressed at 0eb6e39: the release contract now requires both Back and Cancel provide no-write recovery and without creating or changing a configuration, instead of merely requiring the control names. Focused release/docs validation: 53 passed; git diff --check: clean.

A follow-up independent review and fresh exact-head CI are required before merge.

@mohanagy

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mohanagy

Copy link
Copy Markdown
Owner Author

Independent re-review complete at exact head 0eb6e39a74c82d47d1924a77d764137ae13232cf: no remaining findings. The prior medium no-write contract gap is resolved. Exact-head CI run 30579627930 is fully green across Ubuntu/macOS/Windows Node 20/22/24, Linux quality, and Verify.

CodeRabbit remained rate-limited and is not represented as an approval; this independent review is the substantive fallback. External validation under #25/#88 remains incomplete.

@mohanagy
mohanagy merged commit 1a5845e into development Jul 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant