feat(console): guide one MCP setup path at a time - #313
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesConsole setup wizard
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ConsoleUser
participant SetupWizard
participant SetupPathViews
ConsoleUser->>SetupWizard: Select setup source
SetupWizard->>SetupWizard: Update source state
ConsoleUser->>SetupWizard: Continue
SetupWizard->>SetupPathViews: Show selected path
SetupPathViews-->>SetupWizard: Update focus and guidance
ConsoleUser->>SetupWizard: Back or cancel
SetupWizard->>SetupPathViews: Hide paths and reset forms
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/console/console-assets.ts (1)
1703-1720: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winWizard-hide branches skip
hideSetupWizardPaths()and never resetreturningSetupVisible.Both the
attentionCount > 0branch and thediscoveryState === "unavailable"branch inline the old three-line hide sequence instead of the newhideSetupWizardPaths()helper, and neither resetsreturningSetupVisible. If catalog state later flips back toconfigurations.length > 0whilereturningSetupVisibleis still stucktruefrom an earlier wizard session, that branch (1690-1697) skips re-hiding (already hidden) but also never re-shows the wizard — yet it displays "Complete the selected setup path, use Back to choose another path…" with no wizard controls visible. The user can still recover by clicking "Set up another MCP" again, so this is a confusing stale message rather than a hard dead end.🐛 Proposed fix
if (catalog.attentionCount > 0) { - if (onboardingView) onboardingView.hidden = true; - if (presetOnboardingView) presetOnboardingView.hidden = true; - if (clientEntryOnboardingView) clientEntryOnboardingView.hidden = true; + hideSetupWizardPaths(); + returningSetupVisible = false; if (setupWizardView) setupWizardView.hidden = true; if (workspaceView) workspaceView.hidden = true; message("Miftah found configuration files, but none passed every trust and validation check. Review the safe reason summary, correct the expected files, then refresh."); return; } if (catalog.discoveryState === "unavailable") { - if (onboardingView) onboardingView.hidden = true; - if (presetOnboardingView) presetOnboardingView.hidden = true; - if (clientEntryOnboardingView) clientEntryOnboardingView.hidden = true; + hideSetupWizardPaths(); + returningSetupVisible = false; if (setupWizardView) setupWizardView.hidden = true; if (workspaceView) workspaceView.hidden = true; message("Miftah could not safely inspect its standard configuration directory. Correct its local access or start the Console with --config."); return; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/console/console-assets.ts` around lines 1703 - 1720, Update both the catalog.attentionCount and catalog.discoveryState === "unavailable" branches in the setup flow to call hideSetupWizardPaths() instead of duplicating the inline view-hiding statements, and reset returningSetupVisible to false in each branch before returning. Preserve their existing messages and early-return behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/console/console-assets.ts`:
- Line 135: Remove the redundant static “Step 2 of 3” headers from the
connector, existing-client, and browser-sign-in sections, and update the
selectSetupSource flow so only the shared setupWizardStep dynamic header remains
visible. Apply the same cleanup to the related step-label markup around the
referenced setup wizard controls while preserving the section-specific content
and navigation behavior.
---
Outside diff comments:
In `@src/console/console-assets.ts`:
- Around line 1703-1720: Update both the catalog.attentionCount and
catalog.discoveryState === "unavailable" branches in the setup flow to call
hideSetupWizardPaths() instead of duplicating the inline view-hiding statements,
and reset returningSetupVisible to false in each branch before returning.
Preserve their existing messages and early-return behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1e5b67ab-0b36-4891-9ef2-7b7a823c3e5e
📒 Files selected for processing (2)
src/console/console-assets.tstests/console-server.test.ts
|
Resolved the two review findings in
Focused Console contracts, typecheck, lint, build, and diff checks are green. |
1 participant
What changed
Validation
npx vitest run tests/console-server.test.ts tests/console-dashboard-application-service.test.tsnpm testnpm run test:corenpm run test:coverage(95.65% statements, 91.88% branches)npm run lintnpm run typechecknpm run buildnpm run smoke:clinpm run check:packnpm run test:packageRefs #204
Summary by CodeRabbit