docs: explain Miftah 0.5 features and workflows (#40) - #294
Conversation
📝 WalkthroughWalkthroughThe PR adds a Miftah 0.5 feature and usage guide covering setup, profiles, authentication, Console usage, upgrades, and limitations. README and changelog references point to the guide, while contract tests validate documented commands, flags, links, and release metadata. ChangesMiftah 0.5 owner guide
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/whats-new-in-0.5.md`:
- Around line 10-12: Update the “complete multi-account Google Search Console
onboarding path” wording in the 0.5.0 summary and the corresponding later claim
to describe the flow as implemented or reviewed but pending external validation,
avoiding any implication of full production readiness.
In `@tests/v050-feature-guide-contract.test.ts`:
- Around line 121-129: Update the “keeps every local guide link resolvable” test
to validate URL fragments in addition to target files. Preserve external-link
handling, but replace the path-only existence check with GFM-compatible Markdown
anchor validation (or equivalent heading-anchor lookup) so links such as
cli.md#missing-section fail when the referenced heading is absent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5069035c-2356-4a7c-867f-4d58ed1f8faa
📒 Files selected for processing (4)
CHANGELOG.mdREADME.mddocs/whats-new-in-0.5.mdtests/v050-feature-guide-contract.test.ts
|
Review follow-up on exact head
CodeRabbit's incremental review of the new commits is currently rate-limited under its Fair Usage policy (the bot reported a 38-minute wait). This is recorded rather than represented as a new approval. The prior CodeRabbit change request is stale to |
Dismissed as stale to 3ba4f77. Both findings are resolved on exact head 2c1f51d, both review threads are resolved and CodeRabbit acknowledged each fix. Its incremental exact-head re-review was Fair Usage rate-limited, so this dismissal is not represented as bot approval; independent exact-head review found no blockers. See PR comment #294 (comment).
What changed
Why
Issue #40 is a broad roadmap checklist, but it does not give a package owner or user a fast answer to two basic questions: what exactly changed in 0.5, and how do I use it? The new guide provides that product-level orientation without duplicating the full CLI, OAuth, adapter, Console, security, or changelog references.
User impact
An existing 0.4 user can now identify the 0.5 additions in about a minute and copy the correct starting command for each workflow. A new user can distinguish API-key/secret setup, native OAuth, and upstream-owned OAuth without being told that Miftah supports every MCP server or provider.
Refs #40
TDD
The focused contract was added first and failed in five places because the guide, README entry point, feature map, command paths, and changelog record did not exist. The smallest documentation change then made all six guide contracts pass.
Validation
npm test: 1,776 passed / 33 skippednpm run test:core: 425 passed / 26 skippednpm run test:coverage: 1,776 passed / 33 skipped; 95.65% statements, 91.93% branches, 98.66% functions, 95.65% linesnpm run lintnpm run typechecknpm run buildnpm run smoke:clinpm run check:pack: 48 filesnpm run test:package: 26 passedRemaining issue #40 gates
This PR intentionally does not close #40. External multi-account and returning-user validation remain open in #25 and #88, and the roadmap still has other acceptance items that require their own real evidence.
Summary by CodeRabbit
Documentation
Tests