docs: redesign README for first use - #291
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughMiftah’s README was redesigned as a product-first onboarding guide with named profiles, a GitHub quick-start path, authentication routing, safety boundaries, and deeper documentation links. CLI troubleshooting and README contract tests were updated to match the new guidance. ChangesREADME onboarding and documentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/cli.md`:
- Line 199: Update the validation command in the CLI documentation to pass the
exact configuration file used by the client, including a clearly replaceable
absolute path after --config. Keep the surrounding validation guidance
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5e6d29cc-c98e-4c43-97ce-eaba5932ceb5
📒 Files selected for processing (6)
CHANGELOG.mdREADME.mddocs/cli.mddocs/presets-and-clients.mdtests/readme-product-contract.test.tstests/release-version.test.ts
Summary
Why
A first-time reader could not quickly decide whether Miftah fit their multi-account MCP problem because the README had grown into a security and operations reference. This keeps the security and pre-1.0 boundaries intact while making the first read task-oriented and progressively disclosed.
TDD
The new first-use contract was added first and observed failing because the existing README parsed as 709 lines against a 260-line ceiling. The README and linked docs were then changed until the focused product and cross-document contracts passed. Critical package versions, commands, config paths, secret-reference schemes, client paths, OAuth ownership language, Windows refusal wording, and local link anchors remain contract-bound.
Validation
npx vitest run tests/readme-product-contract.test.tsnpm test— 1,769 passed; 33 platform/availability cases skippednpm run test:core— 425 passed; 26 platform/availability cases skippednpm run test:coverage— 95.65% statements/lines, 91.92% branches, 98.66% functionsnpm run lintnpm run typechecknpm run buildnpm run smoke:clinpm run check:pack— 47 files verifiednpm run test:package— 26 passedRefs #290
Parent: #202
This PR intentionally does not close #290. The implementation and documentation contracts are complete, but the acceptance criterion requiring three external evaluators remains open; #25 and #88 also remain open for real-user validation.
Summary by CodeRabbit