Skip to content

test: gate OAuth and Console compatibility across supported platforms - #192

Merged
mohanagy merged 3 commits into
developmentfrom
feat/88-oauth-validation
Jul 22, 2026
Merged

test: gate OAuth and Console compatibility across supported platforms#192
mohanagy merged 3 commits into
developmentfrom
feat/88-oauth-validation

Conversation

@mohanagy

@mohanagy mohanagy commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a deterministic OAuth/Console compatibility suite covering lifecycle, isolation, recovery, Console boundaries, adapters, migration, CLI, redaction, and audit integrity
  • require that suite on Ubuntu, macOS, and Windows with Node.js 20, 22, and 24
  • publish truthful validation and recovery evidence, including the still-unmet external design-partner counts

TDD evidence

  • red: the focused contract failed because test:oauth-console and docs/oauth-console-validation.md did not exist
  • green: focused contract passed (2 tests)
  • dedicated suite passed (33 files, 292 tests)

Validation

  • npm test (109 passed files; 1 platform-skipped; 1,266 passed tests; 20 platform-skipped)
  • npm run test:core
  • npm run test:oauth-console
  • npm run test:coverage (95.39% statements, 91.86% branches)
  • npm run lint
  • npm run typecheck
  • npm run build
  • npm run smoke:cli
  • npm run check:pack
  • npm run test:package

Tracking

Tracks #88. This PR completes the automated compatibility and documentation portion only. It intentionally does not close #88 because five completed external workflows and three returning users are not yet recorded.

Summary by CodeRabbit

  • New Features

    • Added automated OAuth and Console compatibility coverage to the CI process.
    • Added a dedicated test command covering OAuth, identity, Console, CLI, and related compatibility scenarios.
  • Documentation

    • Added validation guidance covering supported environments, deterministic offline testing, security checks, recovery scenarios, and known limitations.
    • Updated OAuth documentation with links to validation and threat-model guidance, plus Console access instructions.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c8a6215a-6779-4a6c-bf9b-3b7304ed9f04

📥 Commits

Reviewing files that changed from the base of the PR and between 3554ea5 and 445c181.

📒 Files selected for processing (3)
  • tests/console-application-service.test.ts
  • tests/console-server.test.ts
  • tests/oauth-console-validation-contract.test.ts
📝 Walkthrough

Walkthrough

The PR adds a deterministic OAuth/Console compatibility test script, runs it in the CI compatibility job, documents validation scope and limitations, updates OAuth support guidance, and adds contract tests for the script, workflow, matrices, and documentation.

Changes

OAuth and Console validation

Layer / File(s) Summary
Define the compatibility suite and validation evidence
package.json, docs/oauth-console-validation.md, docs/oauth-support.md
Adds the test:oauth-console Vitest command and documents its CI matrix, offline fixtures, exercised OAuth/Console behaviors, recovery scenarios, release limitations, and external evidence requirements.
Wire and enforce the CI compatibility gate
.github/workflows/ci.yml, tests/oauth-console-validation-contract.test.ts
Runs the OAuth/Console suite in CI and verifies the command, workflow configuration, OS/Node matrices, and required documentation content.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

  • mohanagy/miftah#90 — Shares the OAuth support documentation and documentation-contract testing surface.
  • mohanagy/miftah#91 — Also updates docs/oauth-support.md and adds OAuth/Console documentation contract tests.
  • mohanagy/miftah#183 — Introduces Console control-plane behavior exercised by the new compatibility suite.

Poem

A rabbit hops through OAuth’s gate,
With Console notes to mark its state.
Offline fixtures softly run,
CI checks them one by one.
Docs keep every boundary bright—
Hop, hop, release evidence right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: gating OAuth and Console compatibility across platforms.
Description check ✅ Passed The PR description is mostly complete, with summary, evidence, validation, and tracking, but it omits the Security impact section.
Linked Issues check ✅ Passed The PR implements the coded OAuth/Console validation scope with a new suite, CI gate, script, and docs.
Out of Scope Changes check ✅ Passed No obvious out-of-scope changes; the edits are all in CI, tests, scripts, and OAuth/Console docs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/88-oauth-validation

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/oauth-console-validation-contract.test.ts`:
- Around line 24-27: Update the workflow assertions in the OAuth/Console
contract test to parse or isolate the compatibility job from ci.yml before
validating expectations. Assert that this job contains the OAuth test step and
both required matrices: Ubuntu/macOS/Windows and Node.js 20/22/24, rather than
checking for strings anywhere in the workflow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 46239cdc-d324-4472-8bda-98b249b40b39

📥 Commits

Reviewing files that changed from the base of the PR and between cf36fdf and 3554ea5.

📒 Files selected for processing (5)
  • .github/workflows/ci.yml
  • docs/oauth-console-validation.md
  • docs/oauth-support.md
  • package.json
  • tests/oauth-console-validation-contract.test.ts

Comment thread tests/oauth-console-validation-contract.test.ts Outdated
@mohanagy
mohanagy merged commit bd971c1 into development Jul 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Release] Validate Console/OAuth compatibility, recovery, and design-partner evidence

1 participant