Skip to content

Commit

Permalink
(2021-03-23, 1115f6c) amp-cid-backup: 1
Browse files Browse the repository at this point in the history
Previous history on prod-config.json:

- 1115f6c - 2021-03-23T03:46:29+08:00 - Ramp up 3p-vendor-split experiment
  • Loading branch information
mohammed-ibra committed Mar 1, 2024
1 parent fd14aeb commit c2ae265
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 10 deletions.
1 change: 0 additions & 1 deletion build-system/global-configs/canary-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"flexAdSlots": 0.05,
"ios-fixed-no-transfer": 1,
"ads-initialIntersection": 1,
"amp-cid-backup": 1,
"sticky-ad-transition": 0.1,
"layout-aspect-ratio-css": 1,
"3p-vendor-split": 0.1,
Expand Down
1 change: 0 additions & 1 deletion build-system/global-configs/prod-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"ios-fixed-no-transfer": 0,
"layout-aspect-ratio-css": 0,
"sticky-ad-transition": 0.02,
"amp-cid-backup": 1,
"3p-vendor-split": 0.01,
"story-ad-placements": 0.01
}
5 changes: 3 additions & 2 deletions src/service/cid-impl.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import {getCookie, setCookie} from '../cookies';
import {getCryptoRandomBytesArray} from '../utils/bytes';
import {getServiceForDoc, registerServiceBuilderForDoc} from '../service';
import {getSourceOrigin, isProxyOrigin, parseUrlDeprecated} from '../url';
import {isExperimentOn} from '../../src/experiments';
import {isIframed} from '../dom';
import {parseJson, tryParseJson} from '../json';
import {tryResolve} from '../utils/promise';
Expand Down Expand Up @@ -181,7 +180,9 @@ class Cid {
this.apiKeyMap_ = null;

/** @const {boolean} */
this.isBackupCidExpOn = isExperimentOn(this.ampdoc.win, 'amp-cid-backup');
this.isBackupCidExpOn =
/* isExperimentOn(this.ampdoc.win, 'amp-cid-backup') // launched: true */
true;
}

/** @override */
Expand Down
6 changes: 0 additions & 6 deletions tools/experiments/experiments-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,6 @@ export const EXPERIMENTS = [
name: 'Move ads placement into layoutCallback',
spec: 'https://github.com/ampproject/amphtml/issues/27068',
},
{
id: 'amp-cid-backup',
name: 'Backup AMP-generated CIDs to Storage.',
spec: 'https://github.com/ampproject/amphtml/issues/29484',
cleanupIssue: 'https://github.com/ampproject/amphtml/issues/29484',
},
{
id: 'layout-aspect-ratio-css',
name: 'Responsive layouts implemented via aspect-ratio CSS',
Expand Down

0 comments on commit c2ae265

Please sign in to comment.