Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutting motion for two dimensional cutting action #607

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ksummers92
Copy link

  • Added additional movement axis to cutter action to support non-linear cutter such as this cutter to allow for smoother operation and provide more leverage
  • Update mmu_macros_vars.cfg defaults to include a y-axis dimension to the compressed position
  • Added some logic to _FILAMETRIX_DO_CUT_MOTION macro to allow backwards compatibility for existing configurations with single dimensional compressed location
    • It assumes that the omitted second dimension is the same as the park location coordinate
  • Tested with and without y-axis dimension provided and operation works as before
  • Tested switching to y-axis cutting direction as the primary direction and it also works
  • Attached video shows exaggerated cutter motion in which x and y position are changing
IMG_2443.MP4

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable_pin_loc_compressed would need to be upgraded in install.sh otherwise this would break previous installs. There is a function called:
read_previous_config() {
Logic should be added at the end of this function (similar to examples that are already there) that convert a previous scalar value to an list of 2 elements. Make sure this is tested to "upgrade" then run again to verify no further changes. I.e. the logic correctly spots a scalar value

Ah, I missed the fact that you handle scalar and a list in the code. Perhaps update the comment for variable_pin_loc_compressed to explain x or y or x,y capability...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with bash enough to update the install.sh to do what would be appropriate to update the parameter, so I decided to handle it this way. I tried to take a stab at it, but I am not sure how to detect if an variable(?) has a length of two? Or contains a ","? The syntax of what it is seeing when pulling out the parameters is lost on me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants