Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Translation missing on dashboard #1049

Closed
kulmjens opened this issue Dec 4, 2016 · 2 comments
Closed

Translation missing on dashboard #1049

kulmjens opened this issue Dec 4, 2016 · 2 comments
Labels

Comments

@kulmjens
Copy link
Contributor

kulmjens commented Dec 4, 2016

Hi there,

on the welcome dashboard there is a missing translation when the inbox has no messages.
In line 11 of /manager/media/style/MODxRE2/welcome.php the string is hardcoded. So I changed this

$code = 'global $_lang;return $_SESSION["nrtotalmessages"] ? sprintf($_lang["welcome_messages"], $_SESSION["nrtotalmessages"], \'<span style="color:red;">\' . $_SESSION["nrnewmessages"] . "</span>") : "No messages";';

into this

$code = 'global $_lang;return $_SESSION["nrtotalmessages"] ? sprintf($_lang["welcome_messages"], $_SESSION["nrtotalmessages"], \'<span style="color:red;">\' . $_SESSION["nrnewmessages"] . "</span>") : $_lang["messages_no_messages"];';

This language index (messages_no_messages) is already available in the language files, so there is no need to update them. :-)

@modx-developer
Copy link
Contributor

+1

no russian translate

@Nicola1971
Copy link
Contributor

fixed in #1090

@yama yama closed this as completed in 3d1f883 Dec 12, 2016
yama added a commit that referenced this issue Dec 12, 2016
Dmi3yy added a commit that referenced this issue Nov 25, 2019
fix(core): composer update and fix tracy Debugger
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants