Skip to content

fix(enhanced): use default runtime export #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2heal1 merged 7 commits into from
Mar 18, 2025
Merged

fix(enhanced): use default runtime export #3601

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
94faa2d
fix(enhanced): use default runtime export
2heal1 Mar 17, 2025
5062742
chore: use esm runtime
2heal1 Mar 17, 2025
c18c58f
chore: revert
2heal1 Mar 17, 2025
0189ca2
chore: use alias runtime path first
2heal1 Mar 17, 2025
27158c7
Merge branch 'main' into fix/use-default-runtime-export
2heal1 Mar 17, 2025
128ecf4
chore: use specify alias
2heal1 Mar 18, 2025
cf3fb02
chore: remove embeded file
2heal1 Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chatty-months-share.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/enhanced': patch
---

fix(enhanced): use default runtime export
20 changes: 10 additions & 10 deletions packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,8 @@ const BundlerRuntimePath = require.resolve(
paths: [RuntimeToolsPath],
},
);
const RuntimePath = require.resolve('@module-federation/runtime', {
paths: [RuntimeToolsPath],
});
const EmbeddedRuntimePath = require.resolve(
'@module-federation/runtime/embedded',
const RuntimePath = require.resolve(
'@module-federation/runtime/dist/index.esm.mjs',
{
paths: [RuntimeToolsPath],
},
Expand Down Expand Up @@ -331,13 +328,16 @@ class FederationRuntimePlugin {
}

setRuntimeAlias(compiler: Compiler) {
const { experiments, implementation } = this.options || {};
let runtimePath = EmbeddedRuntimePath;
const { implementation } = this.options || {};
let runtimePath = RuntimePath;

if (implementation) {
runtimePath = require.resolve(`@module-federation/runtime/embedded`, {
paths: [implementation],
});
runtimePath = require.resolve(
`@module-federation/runtime/dist/index.esm.mjs`,
Comment thread
2heal1 marked this conversation as resolved.
Outdated
{
paths: [implementation],
},
);
}

const alias: any = compiler.options.resolve.alias || {};
Expand Down