Skip to content

Fix react bridge for react 16 #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpeen merged 6 commits into from
Mar 16, 2025
Merged

Fix react bridge for react 16 #3591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b5d3e2
Fix isReact18 check for React versions earlier than 16.13.0
CarltonHowell Mar 13, 2025
35be921
changeset
CarltonHowell Mar 13, 2025
e42fc61
Merge branch 'main' into fix-react-bridge-for-react-16
ScriptedAlchemy Mar 14, 2025
f5c6511
changeset
CarltonHowell Mar 14, 2025
838cff1
Merge branch 'main' into fix-react-bridge-for-react-16
CarltonHowell Mar 14, 2025
d517175
Merge branch 'main' into fix-react-bridge-for-react-16
ScriptedAlchemy Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-clocks-live.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/bridge-react': patch
---

Fix react-bridge version check for React versions earlier than 16.13.0
3 changes: 2 additions & 1 deletion packages/bridge/bridge-react/src/provider/compat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import ReactDOM from 'react-dom';
import { CreateRootOptions, Root } from '../types';

const isReact18 = ReactDOM.version.startsWith('18');
// ReactDOM.version is only available in React 16.13.0 and later
const isReact18 = ReactDOM.version?.startsWith('18');

/**
* Creates a root for a container element compatible with both React 16 and 18
Expand Down