Skip to content

fix(node): delete server module cache if hot reload #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KyrieLii merged 1 commit into from
Mar 13, 2025
Merged

fix(node): delete server module cache if hot reload #3584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dirty-pianos-learn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/node': patch
---

fix(node): delete server module cache if hot reload
31 changes: 13 additions & 18 deletions packages/node/src/utils/hot-reload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,17 +141,7 @@ export const performReload = async (
const req = getRequire();

const gs = new Function('return globalThis')();
const entries: string[] = gs.entryChunkCache || [];

if (!gs.entryChunkCache) {
Object.keys(req.cache).forEach((key) => {
if (requireCacheRegex.test(key)) {
decache(key); // Use decache here
}
});
} else {
gs.entryChunkCache.clear();
}
const entries: Set<string> = gs.entryChunkCache || new Set();

//@ts-ignore
gs.__FEDERATION__.__INSTANCES__.map((i: any) => {
Expand All @@ -172,13 +162,18 @@ export const performReload = async (
globalThis.moduleGraphDirty = false;
globalThis.mfHashMap = {};

for (const entry of entries) {
decache(entry);
}

//reload entries again
for (const entry of entries) {
await getRequire()(entry);
if (!entries) {
Object.keys(req.cache).forEach((key) => {
if (requireCacheRegex.test(key)) {
decache(key); // Use decache here
}
});
} else {
for (const entry of entries) {
decache(entry);
//reload entries again
await getRequire()(entry);
}
}

return true;
Expand Down