Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

Temporarily remove unbreakable. #39

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Temporarily remove unbreakable. #39

merged 1 commit into from
Dec 20, 2024

Conversation

IMB11
Copy link
Contributor

@IMB11 IMB11 commented Dec 20, 2024

  • Mod thinks that you've just broken a tool (and grants you 3x crit+knockback multiplier) when using empty hand during combat. You can easily stack this for an unfair advantage.
  • Breaks flight assistant and grind enchantments math because of the negative durability.

modmuss50
modmuss50 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Owner

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than happy to add this back later once the issues are solved.

@modmuss50 modmuss50 merged commit fd3a586 into modmuss50:main Dec 20, 2024
1 check passed
@sylenthuntress
Copy link
Contributor

More than happy to add this back later once the issues are solved.

Glad to hear that! I've released a patch that fixes the more common bug (that being, bonus knockback + damage on hit) and tweaks some other cosmetic stuff. The issue is that I apparently can't fix the noted incompatibilities:

  • Can't reproduce the bug with grind enchantments (may not be related; neither seems to touch upon the same code) but I did optimize the code in hopes of it resolving the issue
  • The bug with flight assistant seems to be on their end (Issue #32)

@cassiancc cassiancc added the bug Something isn't working label Dec 21, 2024
cassiancc added a commit that referenced this pull request Dec 21, 2024
@cassiancc
Revert "Delete mods/unbreakable.json (#39)"
5c436f9 
This reverts commit fd3a586.
modmuss50 pushed a commit that referenced this pull request Dec 22, 2024
@cassiancc
Re-Add Unbreakable (#44)
bcb2e85 
* Revert "Delete mods/unbreakable.json (#39)"

This reverts commit fd3a586.

* Update Unbreakable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IMB11 @sylenthuntress @modmuss50 @cassiancc