Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADC DMA mode for STM32 F1, F2, F37, F4, F7 and L1 #982

Merged
merged 2 commits into from
Apr 1, 2023
Merged

ADC DMA mode for STM32 F1, F2, F37, F4, F7 and L1 #982

merged 2 commits into from
Apr 1, 2023

Conversation

victorandrehc
Copy link
Contributor

@victorandrehc victorandrehc commented Mar 17, 2023 •
edited
Loading

This Pull request enable a more advanced use of the ADC by adding support to DMA and externally triggered ADC.

Tasks to publish:

  • Double check the f37 family checks, to guarantee that no functionality is left out.
  • Add an example for stm32f401re combining ADC, DMA and an external trigger.
  • Add methods to separately enable and disable the adc (for external clock management)

@victorandrehc
Copy link
Contributor Author

@chris-durand this is the branch with the adc support. I still want to add a small example of that, but I will be able to do that when I have free time, hence in draft mode.

@victorandrehc victorandrehc force-pushed the feature/adc_dma_mode branch 2 times, most recently from 1372cd3 to 9989317 Compare March 17, 2023 22:38
@victorandrehc victorandrehc force-pushed the feature/adc_dma_mode branch 3 times, most recently from 6f8c9c5 to 6dda424 Compare March 22, 2023 12:30
@chris-durand
Copy link
Member

Hi @victorandrehc, I didn't find time yet to review your PR, sorry. I'll have a look tomorrow.

@victorandrehc victorandrehc force-pushed the feature/adc_dma_mode branch 4 times, most recently from 4b31b0b to 8cb5e4f Compare March 24, 2023 23:02
@victorandrehc victorandrehc marked this pull request as ready for review March 25, 2023 07:17
@victorandrehc
Copy link
Contributor Author

@chris-durand I finally had the time to work directly on this PR, but now all tasks should also be completed

@victorandrehc victorandrehc force-pushed the feature/adc_dma_mode branch 2 times, most recently from 9342974 to c45c6bf Compare March 28, 2023 06:42
chris-durand
chris-durand reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/nucleo_f401re/adc_dma/TimerHandler.hpp Outdated Show resolved Hide resolved
examples/nucleo_f401re/adc_dma/main.cpp Outdated Show resolved Hide resolved
examples/nucleo_f401re/adc_dma/TimerHandler.hpp Outdated Show resolved Hide resolved
examples/nucleo_f401re/adc_dma/main.cpp Outdated Show resolved Hide resolved
examples/nucleo_f401re/adc_dma/main.cpp Outdated Show resolved Hide resolved
examples/nucleo_f401re/adc_dma/main.cpp Outdated Show resolved Hide resolved
src/modm/platform/adc/stm32/adc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/adc/stm32/adc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/adc/stm32/adc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/adc/stm32/adc.hpp.in Outdated Show resolved Hide resolved
@victorandrehc
Copy link
Contributor Author

@chris-durand, I saw your review, will work on the changes tomorrow.

@victorandrehc victorandrehc force-pushed the feature/adc_dma_mode branch 5 times, most recently from fca078b to 30343c8 Compare March 29, 2023 07:35
@victorandrehc
Copy link
Contributor Author

@chris-durand all reviews are done.

@chris-durand
Copy link
Member

@chris-durand all reviews are done.

Thanks!

@victorandrehc
Copy link
Contributor Author

@chris-durand last review suggestion was committed already. Can you please set the tag to run the complete test?

@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Mar 31, 2023
@chris-durand
Copy link
Member

@chris-durand last review suggestion was committed already. Can you please set the tag to run the complete test?

Done, I am planning to merge tonight.

@chris-durand chris-durand changed the title Feature/adc dma mode ADC DMA mode for STM32 F1, F2, F37, F4, F7 and L1 Mar 31, 2023
@chris-durand chris-durand force-pushed the feature/adc_dma_mode branch from 58b4e8b to b2ade4b Compare March 31, 2023 19:22
@chris-durand chris-durand force-pushed the feature/adc_dma_mode branch from 8d240b9 to 04ed0a5 Compare April 1, 2023 13:17
@chris-durand chris-durand merged commit 04ed0a5 into modm-io:develop Apr 1, 2023
@salkinium salkinium added this to the 2023q1 milestone Apr 8, 2023
@victorandrehc victorandrehc deleted the feature/adc_dma_mode branch February 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-durand chris-durand chris-durand approved these changes

Assignees
No one assigned
Labels
advanced 🤯 ci:hal Triggers the exhaustive HAL compile CI jobs feature 🚧
Milestone
2023q1
Development

Successfully merging this pull request may close these issues.
3 participants
@victorandrehc @chris-durand @salkinium