[board] add same70 xplained board #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
reviewed
Mar 11, 2023
There was a problem hiding this comment.
Nice, thanks! @chris-durand can say more about the content, since he's modm's SAM expert.
We usually squash BSP additions into two commits: one that adds the BSP, and then another that adds the examples. Just to cut down the noise in the commit history.
There was a problem hiding this comment.
@salkinium Content-wise the examples here are identical to the V71 ones, just pins are changed in places. E70 is basically the same chip as V71 but without automotive qualification and some automotive multimedia bus peripheral. Fine with me.
salkinium
approved these changes
Mar 12, 2023
lgili
force-pushed
the
feature/add-same70-xplained-board
branch
from
a9c2ca8 to
80f2249
Compare
salkinium
reviewed
Mar 13, 2023
lgili
force-pushed
the
feature/add-same70-xplained-board
branch
2 times, most recently
from
9bf364e to
6ed82bd
Compare
salkinium
force-pushed
the
feature/add-same70-xplained-board
branch
from
6ed82bd to
a38feca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add same70 xplained board and tested all examples on board
Examples