Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ext] Update all submodules to latest versions #936

Merged
merged 7 commits into from
Jan 1, 2023
Merged

[ext] Update all submodules to latest versions #936

merged 7 commits into from
Jan 1, 2023

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Dec 26, 2022 •
edited
Loading

This updates all submodules in preparation for the 2022q4 release.

  • CMSIS-DSP v1.14.2: was split off from the CMSIS_5 repository into its own repo and this adds that repo and updates it to the latest version. Only very minor changes were required, so I don't expect anything to break.
  • FreeRTOS 202212: Only minor config adaptation.
  • FatFS v0.15: Only minor config adaptation.
  • TinyUSB v0.14.0: Only minor config adaptation.
  • Printf v6.1.0: Only minor config adaptation.
  • ARM GCC 11.3 and 12.2 sometimes links against Newlib syscalls in big projects (FreeRTOS+TCP pulls in _gettimeofday somehow, LVGL all file syscalls). I think this is an issue with the linker garbage collection, since no source code calls any of these functions directly. I've added weak empty stub implementations for now.
  • The upgrade of the SAM header files leads to issues with redefinitions.
  • All other submodules updated without issues.

Tested in hardware:

  • CMSIS-DSP on NUCLEO-F429ZI
  • TinyUSB on RP2040
  • FatFs + TinyUSB on BlackPill F411
  • LVGL on DISCO-F469I
  • ETL on NUCLEO-F429ZI
  • NanoPB on NUCLEO-F429ZI

@salkinium salkinium added this to the 2022q4 milestone Dec 26, 2022
@salkinium
Copy link
Member Author

Looks like the macOS CI is broken again??? Seems to fail when calling which scons. Ugh.

@chris-durand
Copy link
Member

Could @chris-durand or @rleh test the CMSIS-DSP examples on NUCLEO-F429ZI until the 22Q4 release?

I also don't have access to any STM32 hardware right now, but accidentally took a SAMV71 board with me. I will try running the tests on that one.

@chris-durand
Copy link
Member

The tests have all passed on the SAMV71 board.

@salkinium
Copy link
Member Author

The tests have all passed on the SAMV71 board.

Fantastic, thanks!
I'm currently updating the rest of the submodules, and I'll have my hardware again soon, so I can test the rest too.

@salkinium salkinium changed the title [ext] Update CMSIS-DSP to v1.14.2 [ext] Update all submodules to latest versions Dec 27, 2022
@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Dec 27, 2022
@salkinium
Copy link
Member Author

I've changed this PR to also update all other submodules. @chris-durand the update of the SAM header files leads to issues with redefinitions etc. I think you already mentioned that to me some time ago, so I would suggest to fix it later if it's too much of a hassle for now.

I'll update the CI to GCC11 next.

@salkinium
Copy link
Member Author

I'll update the CI to GCC11 next.

I'm not going to do this, since I cannot test avr-gcc 12 since it doesn't compile on macOS 13, because of a linker bug?
So I'm not going to update the compiler for this release and instead just continue to use GCC 10.

@salkinium salkinium force-pushed the feature/cmsis-dsp branch 2 times, most recently from 1fcb687 to a2e2251 Compare January 1, 2023 19:03
@salkinium salkinium added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Jan 1, 2023
@salkinium salkinium mentioned this pull request Jan 1, 2023
Merged
6 tasks
@salkinium salkinium merged commit a2e2251 into modm-io:develop Jan 1, 2023
@salkinium salkinium deleted the feature/cmsis-dsp branch January 1, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs enhancement 🌈 process 📊
Milestone
2022q4
Development

Successfully merging this pull request may close these issues.
2 participants
@salkinium @chris-durand