Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix STM32H7 RCC clock output #853

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Fix STM32H7 RCC clock output #853

merged 2 commits into from
Apr 30, 2022

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Apr 29, 2022 •
edited
Loading

Fix STM32H7 RCC clock output and add connect() method for alternate function configuration of clock outputs to RCC driver. Tested in hardware on a STM32H755ZI-Q Nucleo.

I haven't yet added an example because support for STM32H7 dual-core is still work in progress. It will go into #844.

Fixes #852

@chris-durand chris-durand added this to the 2022q2 milestone Apr 29, 2022
@chris-durand
Copy link
Member Author

Does anyone have an idea why the Windows hosted examples fail? I have already restarted the job once. This PR only touches platform/clock/stm32/rcc.hpp.in …

@salkinium
Copy link
Member

Does anyone have an idea why the Windows hosted examples fail?

I've seen it on other PRs too, I think something changed on their end, maybe we need to upgrade the OS version or something…

@chris-durand
Copy link
Member Author

The Windows unit test executable crashes:

Linking········ scons-release\test.exe
scons: *** [phony_target] Error 3221225477
scons: building terminated because of errors.

@chris-durand
Copy link
Member Author

The windows CI fails on all PRs. The compiler version is exactly the same as on the last runs where the unit tests succeeded. I could also exclude that any changes we made on modm recently cause this. I have just rerun the Windows pipeline for a state that previously was fine but it also fails now.

@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Apr 30, 2022
@chris-durand chris-durand requested review from salkinium and rleh April 30, 2022 14:44
salkinium
salkinium approved these changes Apr 30, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Do you want this merged now, or is this going into the large PR later?

@chris-durand
Copy link
Member Author

Nice! Do you want this merged now, or is this going into the large PR later?

I'd rather like this to be merged soon. I am working on STM32 camera interface support and need the clock out to supply the camera with a reference clock. I'm currently testing this on a H7 dual-core for which support is also not merged yet. It would certainly make my git workflow easier not having to deal with 3 feature branches at once 😉

@salkinium salkinium merged commit 6e7c12f into modm-io:develop Apr 30, 2022
@chris-durand chris-durand deleted the fix/stm32h7_clock_out branch April 30, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@rleh rleh Awaiting requested review from rleh

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs fix 💎
Milestone
2022q2
Development

Successfully merging this pull request may close these issues.

STM32H7 RCC clock output configuration not working
2 participants
@chris-durand @salkinium