[sam] Read unique ID correctly for SAMG55 #824
Conversation
Wow… I don't even |
mcbridejc
force-pushed
the
fix/samg-usb-serial
branch
from
f1efdf2 to
9c50998
Compare
These parts! Lets just say I regret some of my past decisions. I also learned today that while the reset controller claims to report whether the last reset was caused by a watchdog expiration vs NRST being pulled low, this only works if the rise time on the NRST pin is less than one SLOWCLK period. In other words, if you put a debounce RC on your reset pin. I guess they just really wanted to save a register?!? I don't know. Actually I don't even see how it does, because you still have to latch the state of the reset pin after reset releases. Anyway, that's how it is 🤷 |
|
I added a second commit to add the noinline attribute to modm_fastcode. I didn't squash it since they are separate things. Let me know if you prefer to open a second PR for it. |
Sure, will do. But out of curiosity, when there aren't any conflicts, doesn't the github "rebase and merge" button achieve the same thing? |
|
No, it "rebases" by merging the develop into the PR branch and then merges that into the develop branch. GitHub always creates a merge commit via the Web UI, I think it's like a branding gimmick for them. |
|
Since I write the quartely changelog updates, having a clean looking Git history is very helpful for me, and it also just looks nice to have a "dense" history not diluted by (empty) merge commits everywhere.. |
mcbridejc
force-pushed
the
fix/samg-usb-serial
branch
from
9c50998 to
845840e
Compare
Yeah that makes sense. I naively thought the button labeled rebase would actually rebase. |
SAMG55 parts have an odd process for reading the unique ID. You have to send a command to the flash controller, and then the flash memory plane is used for reading the ID. Until you send another command to disable it, flash access is disabled, which means this has to be done from code in RAM.