[sam] Add driver for SAMG timer channels #823
Conversation
mcbridejc
force-pushed
the
feature/samg-timer-driver
branch
from
d4d8409 to
4ca32ab
Compare
| MODM_ISR(TC3) | ||
| { | ||
| // Clear pending interrupts by reading them | ||
| (void)TimerChannel3::getInterruptFlags(); |
There was a problem hiding this comment.
| (void)TimerChannel3::getInterruptFlags(); | |
| TimerChannel3::acknowledgeInterruptFlags(); |
At least this is the informal naming scheme for the interrupt flags in modm.
Can be implemented like that though.
There was a problem hiding this comment.
Yeah I think I had to think about this a bit. On STM32, you clear the flag with a write. On SAMG5x you clear it with a read, so the acknowledgeInterruptFlags() function, if I added it, would be the same as the getInterruptFlags() function, except I guess not returning the read value. Adding the extra method does allow for more similar API I suppose, and it's likely to be inlined as a single instruction anyway so I guess it doesn't hurt to have both.
There was a problem hiding this comment.
Actually, it won't match the STM32 API anyway, because acknowledgeInterruptFlags takes a mask argument, but there's no way to acknowledge interrupt flags individually on this chip.
There was a problem hiding this comment.
One thing that I do not really like about the name getInterruptFlags() is that functions named get... usually perform a read operation without side effects. From its name it's not obvious it clears any flags. That's why the code above needs the comment.
There was a problem hiding this comment.
I can't come up with a better name despite some overly verbose alternatives like readAndClearInterruptFlags().
There was a problem hiding this comment.
I'm happy with renaming getInterruptFlags to readAndClearInterruptFlags, adding an acknowledgeInterruptFlags that is basically a wrapper on getInterruptFlags, or leaving it as is.
There was a problem hiding this comment.
Let's leave it as is and fix it later if it becomes an issue.
salkinium
force-pushed
the
feature/samg-timer-driver
branch
from
4ca32ab to
f5cdf6a
Compare
No description provided.