Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stm32] Add STM32L5 #800

Merged
merged 15 commits into from
Jan 19, 2022
Merged

[stm32] Add STM32L5 #800

merged 15 commits into from
Jan 19, 2022

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Jan 2, 2022 •
edited
Loading

Add STM32 L5 devices

  • Update device files
  • Add STM32L5 / Cortex-M33 support
  • Port RCC driver
  • Nucleo-L552ZE-Q BSP
  • DMA
  • ADC
  • Port fibers to Cortex-M33, just works
  • Fix freertos
  • Add CI jobs
  • Add and test Nucleo-L552ZE-Q examples
    • blink
    • freertos
    • DMA
    • ADC

salkinium
salkinium reviewed Jan 2, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! Finally a real Cortex-M33 device, only ever played around with those on a crappy simulator!

@chris-durand
Copy link
Member Author

So far so good! Finally a real Cortex-M33 device, only ever played around with those on a crappy simulator!

@salkinium Are there any hidden surprises with Arm-v8m? I just had a very short look at the architecture manual. Apart from all this Trust Zone stuff everything looks quite similar to v7m.

@salkinium
Copy link
Member

Should be backwards compatible for v7m, you have to explicitly enable the TrustZone stuff, just like you have to explicitly enable unpriviledged mode in v7m.

@chris-durand chris-durand force-pushed the feature/stm32l5 branch 4 times, most recently from 8c061d8 to fbd3990 Compare January 2, 2022 22:11
@chris-durand
Copy link
Member Author

The docs pipeline fails because of freertos. Our clone does not include CM33 support. Will be fixed soon: modm-ext/freertos-partial#5

@chris-durand chris-durand mentioned this pull request Jan 17, 2022
Merged
3 tasks
@chris-durand
Copy link
Member Author

Freertos is now working with modm-ext/freertos-partial#5

@chris-durand
Copy link
Member Author

I guess fibers don't require any changes as long as we don't support TrustZone.

@chris-durand
Copy link
Member Author

The unit tests succeed but take about 30 seconds to run. Do we have any test that would take that long?

@chris-durand
Copy link
Member Author

ADC, DAC and DMA are working as well.

@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Jan 18, 2022
@salkinium
Copy link
Member

The unit tests succeed but take about 30 seconds to run. Do we have any test that would take that long?

I think that's because of one very thorough driver test by Sascha, but I don't remember which one anymore. We really need to execute these tests automatically, otherwise nothing will ever get fixed.

salkinium
salkinium reviewed Jan 18, 2022
View reviewed changes
ext/arm/core.lb Show resolved Hide resolved
src/modm/board/nucleo144_arduino_l5.hpp Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.cpp.in Show resolved Hide resolved
src/modm/platform/clock/stm32/rcc.hpp.in Show resolved Hide resolved
salkinium
salkinium approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you very much!

@salkinium
Copy link
Member

Squash?

@chris-durand
Copy link
Member Author

Squash?

Rebased and squashed the fixup commits.

@salkinium salkinium added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Jan 19, 2022
@chris-durand
Copy link
Member Author

The Windows ARM toolchain download does not work and fails the CI, meh.

@chris-durand
Copy link
Member Author

I have restarted the Windows job, let's see.

@salkinium salkinium merged commit 187ddd8 into modm-io:develop Jan 19, 2022
@chris-durand chris-durand deleted the feature/stm32l5 branch January 19, 2022 21:12
@salkinium salkinium added this to the 2022q1 milestone Jan 23, 2022
@rleh rleh mentioned this pull request Apr 4, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@rleh rleh Awaiting requested review from rleh

Assignees
No one assigned
Labels
advanced 🤯 ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧
Milestone
2022q1
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-durand @salkinium