Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add workaround for doxypress crash for mcp7941x driver #799

Merged

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Jan 1, 2022

Fix docs generator crash caused by the mcp7941x driver in the Q4 release (see #797)

@chris-durand chris-durand force-pushed the fix/doxypress_crash_mcp7941x branch from 6837a2c to 78a1dcd Compare January 1, 2022 18:38
@chris-durand
Copy link
Member Author

License header issue fixed as well

@chris-durand chris-durand requested a review from salkinium January 1, 2022 18:39
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium
Copy link
Member

I'll check if I can teach the docs python script in the build-docs-test job to fail on segfault, that would prevent this issue in the future. So there may be some test commits on this branch.

@chris-durand
Copy link
Member Author

Our doxypress config has "clang-parsing": false. Seems we are using the broken legacy doxygen lex parser that does not really understand modern C++. Is that on purpose?

@salkinium
Copy link
Member

Is that on purpose?

Probably not, I think we took the default and just changed what was needed. If it works without having clang installed, then we can change it.

@chris-durand
Copy link
Member Author

"clang-parsing": true segfaults for me 🙀
Let's not mess with it right now ...

@salkinium salkinium force-pushed the fix/doxypress_crash_mcp7941x branch from 47aa1d2 to be1ea15 Compare January 1, 2022 22:16
@salkinium
Copy link
Member

salkinium commented Jan 1, 2022

Failing properly now: https://github.com/modm-io/modm/runs/4681342161?check_suite_focus=true
And not failing with the fix.

@salkinium salkinium merged commit be1ea15 into modm-io:develop Jan 2, 2022
@salkinium
Copy link
Member

When you have time tomorrow @rleh, you can copy the develop folder to 2021q4 release to archive it.

@rleh
Copy link
Member

rleh commented Jan 2, 2022

Already on my to-do list :)
Done ✅

@chris-durand chris-durand deleted the fix/doxypress_crash_mcp7941x branch January 2, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants