-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] modm::Saturated #780
Conversation
473cefa
to
6c25b15
Compare
6c25b15
to
9d0c642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
c358128
to
8bfb47a
Compare
8bfb47a
to
d21beb8
Compare
Done! Please review @salkinium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely!
fba61f5
to
c9d4d44
Compare
Could be merged @salkinium 😋 |
... still in exams phase? |
Way worse: master thesis phase for the next ~6 months. |
Rebase and squash? |
c9d4d44
to
64db86f
Compare
So i stay in @-poke-mode for ~6 months @salkinium 😬 !? Hope you find a breath in between. |
64db86f
to
53a15f6
Compare
You should probably always stay in poke mode, since you push so many commits that I don't really know when do reviews or merges 😜 So it's best if you just tell me, that helps me and you. |
53a15f6
to
c0a8c51
Compare
Thanks for the feedback, i thought like pushing commits that hard isn't normal. I rely to much on githubs CI and it always surprises me - repeating - what else got broken with my changes. I can run anything within '/test' but there is more! Running githubs complete CI locally would save a ton of nerves and CO2. Is there some 'best practice' to read? @salkinium |
See this Readme here: https://github.com/modm-io/modm/tree/develop/test#unit-tests |
There are also a bunch of scripts in |
The compile-all tests take a very long time locally, I suggest only running them only locally for a subset of devices if the |
Perfect. Thank you! |
To PR the generic colors nextly from #665 , i would like to PR this fixed
modm::Saturated
first.TODO