Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC driver for samg series #753

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Conversation

mcbridejc
Copy link
Contributor

No description provided.

src/modm/platform/adc/samg/adc.cpp Outdated Show resolved Hide resolved
src/modm/platform/adc/samg/adc.hpp Outdated Show resolved Hide resolved
src/modm/platform/adc/samg/adc.hpp Outdated Show resolved Hide resolved
src/modm/platform/gpio/sam/config.hpp.in Outdated Show resolved Hide resolved
@salkinium
Copy link
Member

Want to add an example, so the CI tests this code?

@mcbridejc
Copy link
Contributor Author

Want to add an example, so the CI tests this code?

I have a UART PR to to follow this one; mind if I put if I include an example that reads ADC values and prints to UART in that PR to cover both?

@salkinium
Copy link
Member

Then let's merge the UART PR first with a non-ADC example and then we can depend on that here for the ADC reading and printing.

src/modm/platform/adc/samg/adc.hpp Outdated Show resolved Hide resolved
src/modm/platform/adc/samg/adc.hpp Show resolved Hide resolved
@mcbridejc mcbridejc force-pushed the feature/samg-adc branch 2 times, most recently from bd9e637 to a76a627 Compare October 23, 2021 02:44
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done as always!

(Just some trailing whitespace issues)

examples/samg55_xplained_pro/adc-uart/main.cpp Outdated Show resolved Hide resolved
Adds basic polling driver for ADC, and updates the UART example to
include ADC readings.
@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Oct 23, 2021
@salkinium salkinium added this to the 2021q4 milestone Oct 23, 2021
@salkinium salkinium merged commit 82bc4a9 into modm-io:develop Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs feature 🚧
Development

Successfully merging this pull request may close these issues.

2 participants