-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Make operators new
and delete
weak symbols by default
#747
Conversation
Hm, so would it also solve the issue if we left the operator delete functions empty by default? Then the new/malloc would still trigger the linker error message, but not this issue right? And then only if the |
I mean, an application which is never calling new in the first place cannot call delete and expect that to work? |
👍 , sounds reasonable. |
I'll push a commit to implement this, but we're keeping the weak symbols, they could be useful. |
I'd prefer to put |
Honestly, this was the behavior I was expecting. If |
Signed-off-by: delphi <[email protected]>
a523e7f
to
387a625
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, always nice to fix another corner case!
This change makes operators
new
anddelete
weak symbols by default. See #746