Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[board] DevEBox STM32H750VB with blink example #678

Merged
merged 2 commits into from
Sep 16, 2021
Merged

[board] DevEBox STM32H750VB with blink example #678

merged 2 commits into from
Sep 16, 2021

Conversation

hshose
Copy link
Contributor

@hshose hshose commented Sep 9, 2021

Some practical relevance since H750 can be purchased from lcsc

The DevEBox STMH7xx schematics are available here

salkinium
salkinium reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

(You still need to add the example to the CI.)

tools/openocd/modm/stm32h7xx_devebox.cfg Outdated Show resolved Hide resolved
tools/openocd/modm/stm32h7xx_devebox.cfg Show resolved Hide resolved
src/modm/board/devebox_stm32h750vb/board.xml Outdated Show resolved Hide resolved
src/modm/board/devebox_stm32h750vb/board.hpp Outdated Show resolved Hide resolved
@hshose hshose force-pushed the feature/devebox_h750vbt6 branch from e4c3dbe to 5ddbfc2 Compare September 12, 2021 14:30
@salkinium salkinium force-pushed the feature/devebox_h750vbt6 branch from 5ddbfc2 to 6b3a932 Compare September 16, 2021 16:13
salkinium
salkinium approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogogogogogogo 🚀🚀🚀🚀🚀🚀

@salkinium salkinium added this to the 2021q3 milestone Sep 16, 2021
rleh
rleh requested changes Sep 16, 2021
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blinky/ example should be named blink/ for consistency with all other boards.

@salkinium salkinium force-pushed the feature/devebox_h750vbt6 branch from 6b3a932 to 6abfb15 Compare September 16, 2021 16:27
@salkinium salkinium force-pushed the feature/devebox_h750vbt6 branch from 6abfb15 to 056d228 Compare September 16, 2021 16:30
@salkinium salkinium force-pushed the feature/devebox_h750vbt6 branch from 056d228 to 34f255c Compare September 16, 2021 17:21
chris-durand
chris-durand requested changes Sep 16, 2021
View reviewed changes
src/modm/board/devebox_stm32h750vb/board.hpp Outdated Show resolved Hide resolved
src/modm/board/devebox_stm32h750vb/board.hpp Outdated Show resolved Hide resolved
@salkinium salkinium force-pushed the feature/devebox_h750vbt6 branch from 34f255c to 0dbb152 Compare September 16, 2021 17:56
@salkinium salkinium force-pushed the feature/devebox_h750vbt6 branch from 0dbb152 to b4eddeb Compare September 16, 2021 18:03
@salkinium salkinium requested a review from rleh September 16, 2021 19:02
@salkinium salkinium merged commit b4eddeb into modm-io:develop Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@chris-durand chris-durand chris-durand approved these changes

@rleh rleh rleh approved these changes

Assignees
No one assigned
Labels
example 🔑 feature 🚧
Milestone
2021q3
Development

Successfully merging this pull request may close these issues.
4 participants
@hshose @salkinium @rleh @chris-durand