Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SAMG devices #676

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

mcbridejc
Copy link
Contributor

Adding basic SAMG support with GPIO and clock setup.

Still work-in-progress; just trying to see if the CI will run.

@salkinium
Copy link
Member

I think this is based on a old version of modm (Nov 2020), you should rebase your changes onto current develop, since the CI config changed meanwhile.

@salkinium
Copy link
Member

I also strongly recommend using a feature/samg branch, so that you can rebase onto the develop branch easier.

src/modm/platform/gpio/sam/enable.cpp.in Outdated Show resolved Hide resolved
src/modm/platform/gpio/sam/pin.hpp Show resolved Hide resolved
src/modm/platform/core/sam/module.lb Show resolved Hide resolved
src/modm/platform/clock/samg/clockgen.cpp Outdated Show resolved Hide resolved
src/modm/platform/clock/samg/clockgen.cpp Outdated Show resolved Hide resolved
src/modm/platform/gpio/sam/module.lb Outdated Show resolved Hide resolved
@mcbridejc
Copy link
Contributor Author

Side note @salkinium: While debugging the doc build issue, I had to run the build locally -- because the output (tens of thousands of lines) is basically unreadable on github -- and got this error for every target:

Finished generating documentation for device nucleo-g474re.
Deduplicating files for stm32g474ret6...
Error generating documentation for device nucleo-g474re: [Errno 2] No such file or directory: '/tmp/tmp23ig2502/nucleo-g474re/modm/docs/html' -> '/tmp/tmp23ig2502/output/develop/api/nucleo-g474re'
Traceback: Traceback (most recent call last):
  File "tools/scripts/docs_modm_io_generator.py", line 226, in create_target
  File "/usr/lib/python3.8/pathlib.py", line 1359, in rename
    self._accessor.rename(self, target)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp23ig2502/nucleo-g474re/modm/docs/html' -> '/tmp/tmp23ig2502/output/develop/api/nucleo-g474re'

I see some recent changes in docs_modm_io_generator.py that may be related. I haven't figured out what's going on here, but I'm guessing it's something different between my system (building on Ubuntu) and the CI. If CI builds correctly, it's not an issue at the moment, but I wanted to share the data point.

(If this output looks a bit different from yours, note that I hacked in the traceback printing while debugging).

@mcbridejc
Copy link
Contributor Author

If CI comes back happy, and you are happy with this @salkinium, then so am I.

@mcbridejc mcbridejc marked this pull request as ready for review September 8, 2021 21:30
@salkinium salkinium added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Sep 8, 2021
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Polish, squash, rebase?

src/modm/board/samg55_xplained_pro/board.hpp Show resolved Hide resolved
src/modm/platform/clock/samg/clockgen.hpp Outdated Show resolved Hide resolved
src/modm/platform/clock/samg/clockgen.hpp Outdated Show resolved Hide resolved
- Basic clock configuration
- Gpio driver
- BSP for samg55_xplained_pro
- simply blinky example for that board
@salkinium salkinium added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Sep 8, 2021
@salkinium salkinium merged commit c148bf8 into modm-io:develop Sep 9, 2021
@salkinium salkinium added this to the 2021q3 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced 🤯 ci:hal Triggers the exhaustive HAL compile CI jobs feature 🚧
Development

Successfully merging this pull request may close these issues.

2 participants