-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Smart Response XE #669
Conversation
You can actually update the modm-devices submodule to your fork's commit (use git add remote to add your fork, then choose the commit) without merging and the CI will work fine. That way you can work on both PRs simultaneously and we can merge them together. I would also prefer to have the BSP and an example in this PR so that the CI can perhaps catch additional issues. |
Indeed it works pretty well. However the modm-devices pointer in ext/ hasn't been updated in a while so my commit pulls in more changes than just for ATmega128RFA1. I will add some initial SRXE BSP and example (blinker and maybe uart), but the final implementation will need some separate PRs (e.g. I need to write LCD display driver etc etc). |
e105953
to
584528c
Compare
Okay, I think I fixed all the immediate problems. Please let me know if blinky example is good enough for initial PR or it should be more complete with UART and logger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise excellent!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
This change requires merging modm-io/modm-devices#68 first.