-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ext] Embedded Template Library ETL #667
Conversation
Hm, ETL is certainly very large, I was wondering if there's any way to modularize ETL just a little. Something along the lines of the documentation grouping: https://www.etlcpp.com/documentation.html That would allow us to use ETL inside modm without forcing a lot of file to be generated all the time. We don't have to do it right away, only when we want to start using ETL inside modm. |
Waaa!! You're reading my thoughts. I've just scratched my head on how to get a python-like dict in C++ and here it is! |
I have also added etl to our modm repositories and we are keen on using it excessively 👍 don't forget to add the etl::string to your MODM_LOGGER class, so that we can print etl::strings as well! :)
which is awkward but fine, i guess :p |
@rleh is it possible to address my todo list above until the Q3 release in 10 days? I don't think we can modularize the library since they update their code so much… |
Hopefully I'll find some time next week... |
ed3b1c9
to
aca9515
Compare
We should probably have a better example. |
211b8ba
to
fa0e3ef
Compare
@rleh please review and test. |
Co-authored-by: Niklas Hauser <[email protected]>
ba24264
to
3ef409b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve ✅
Co-authored-by: Raphael Lehmann <[email protected]>
3ef409b
to
2ef7a29
Compare
profiles/
folder anddoxygen.h
ETL_ASSERT
etc should be rerouted tomodm_assert
. I think replacing theerror_handler.h
file should be enough for that.ETL_*
defined are defaulted, likeETL_CPP17_SUPPORTED
etc.<etl_local.h>
mechanism? => ETL usesetl_profile.h
themselves.